magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

CustomerCart graphql: address country label getting code not full name #36916

Open ronakchauhan opened 1 year ago

ronakchauhan commented 1 year ago

Magento version: 2.4.5 Graphql: customerCart

Request: { customerCart { billing_address { country { label code } firstname lastname } shipping_addresses { country { label code } } } }

Response: { "data": { "customerCart": { "billing_address": { "country": { "label": "DE", "code": "DE" }, "firstname": "Ronak", "lastname": "Chauhan" }, "shipping_addresses": [ { "country": { "label": "DE", "code": "DE" } } ] } } }

Expected result: "country": { "label": "Germany", // this should be full name of the country "code": "DE" },

m2-assistant[bot] commented 1 year ago

Hi @ronakchauhan. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo, here is your Magento Instance: https://69ba96193a342f401ed31ba6ca4408e9.instances.magento-community.engineering Admin access: https://69ba96193a342f401ed31ba6ca4408e9.instances.magento-community.engineering/admin_0823 Login: d97df304 Password: 73174fb4f65b

engcom-Bravo commented 1 year ago

Hi @ronakchauhan,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots. As per Magento devdocs https://r-martins.github.io/m1docs/guides/v2.4/graphql/queries/cart.html#cart-output it is expected behaviour of magento not a bug.Kindly go through with this document.

In response it will give code for country.

Screenshot 2023-02-24 at 12 28 00 PM

Please let us know if you are still facing any issue.

Thanks.

ronakchauhan commented 1 year ago

It is expected behaviour as it shown in Magento documentation but this is not logically correct response. Country label should get Full Country name not country code.

engcom-Bravo commented 1 year ago

Hi @ronakchauhan,

Thanks for your update,

We have gone through the main description and found that this is not related to any bug but existing behavior of Magento. Hence can be considered as an enhancement Hence marking this ticket as a feature request to process further. Thank you.

m2-assistant[bot] commented 1 year ago

Hi @chernenm. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


nambss commented 3 weeks ago

Hi @ronakchauhan,

Thanks for your update,

We have gone through the main description and found that this is not related to any bug but existing behavior of Magento. Hence can be considered as an enhancement Hence marking this ticket as a feature request to process further. Thank you.

it's ridiculous to say this isn't a bug

12 34

label field will always return the same value as code field. it's country_code. So what is the difference between label field and code field when they always return the same value? LOL