JQuery UI loading performance

[onlinebizsoft]

Summary

Magento improved from time to time but seems to break performance again after a recent update

https://github.com/magento/magento2/issues/32810 - we removed some unnecessary dependencies from this ticket https://github.com/magento/magento2/commit/fa87f9299985cf0b7d1b778f056bfceff1aec231 - after an upgrade, dialog.js get wrong again

Examples

https://github.com/magento/magento2/blob/fa87f9299985cf0b7d1b778f056bfceff1aec231/lib/web/jquery/ui-modules/widgets/dialog.js

Proposed solution

We should review and remove dependencies from here again

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [X] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @onlinebizsoft. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[onlinebizsoft]

@mrtuvn can you check and confirm?

[m2-assistant[bot]]

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @onlinebizsoft,

Thanks for the report and collaboration!

As per the description of this issue as well as https://github.com/magento/magento2/issues/32810, it seems that we need to optimize the lib/web/jquery/ui-modules/dialog.js file.

But to speed up the processing of this issue, please provide us with the following information:

• Information on your environment
• Steps to reproduce
• Expected and actual results

Thanks

[engcom-Hotel]

Hello @onlinebizsoft,

Have you got a chance to check the above comment?

Thanks

[onlinebizsoft]

@engcom-Hotel

Information on your environment Steps to reproduce

I don't think we need any specific environment because I have mentioned clearly where the issue is wrong. I'm not sure in which case the dialog.js will be loaded (maybe it is loaded by default or you can declare a JS which use it)

Expected and actual results

When dialog.js is used, it should not load TOO many other JS libs which is not necessary as in my screenshot.

You can see that the issue was fixed one time in past in ticket https://github.com/magento/magento2/issues/32810