magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.32k forks source link

Ui-select wrong behaviour #36954

Open Nuranto opened 1 year ago

Nuranto commented 1 year ago

Preconditions and environment

Steps to reproduce

  1. Open Pagebuilder in any CMS content
  2. Add a button
  3. Press configure icon on that button Capture d’écran 2023-03-03 à 15 22 01
  4. Set "Button Link" to Product
  5. Search for a product.

Expected result

The results are shown, without intermediate results

Actual result

The results are shown, with intermediate results and duplicate

Capture d’écran 2023-03-03 à 15 31 59

Additional information

It is not 100% reproductible. I guess it depends on how many XHR requests are sent, and how long they last, so you might have to play a bit with it to reproduce.

Solution is probably to cancel active XHR when a new XHR is sent. See vendor/magento/module-ui/view/base/web/js/form/element/ui-select.js::processRequest()

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 year ago

Hi @Nuranto. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

engcom-Dash commented 1 year ago

@magento give me 2.4-develop instance

engcom-Dash commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash, here is your Magento Instance: https://51c064c8947f29336949f176a459757d.instances.magento-community.engineering Admin access: https://51c064c8947f29336949f176a459757d.instances.magento-community.engineering/admin_b13e Login: 6997b447 Password: 7c7fe8bbf3de

engcom-Dash commented 1 year ago

Hi @Nuranto ,

We are trying to reproduce the issue in 2.4-develop instance,We are not able to reproduce the issue.

Description: Ui-select wrong behaviour Prerequisite: Magento version 2.4-develop instance PHP Version 8.1 Actual Result: The results are shown, with intermediate results and duplicate Expected Result: The results are shown, without intermediate results Steps to Reproduce: 1.Open Pagebuilder in any CMS content 2.Add a button 3.Press configure icon on that button 4.Set "Button Link" to Product 5.Search for a product.

Screenshots for your reference:

ui1 ui2

We are getting expected result as The results are shown, without intermediate results.Kindly Provide more information if the issue is still reproducible.

Let us know if we missing anything

Regards,

Nuranto commented 1 year ago

Hi @engcom-Dash,

Yes, as I said it could be tricky to reproduce the issue. (On my production environment it happens almost all the time, but on a fresh install with small amount of data it was indeed difficult to reproduce)

You can try to play with the speed of typing. You could also try to add throttling simulation to your browser (Network tab of Chrome dev tools).

engcom-Lima commented 1 year ago

:heavy_check_mark: Issue confirmed

Issue got reproduced in 2.4-develop branch.

Description: When product is searched in the button field setting then, it is showing duplicate result.

Pre-requisite: Fresh magento 2.4-develop should be installed.

Steps to reproduce:

  1. Open Pagebuilder in any CMS content
  2. Add a button
  3. Press configure icon on that button
  4. Set "Button Link" to Product
  5. Search for a product.

Expected result: It should show correct result while searching a product. Actual result: It is showing correct as well as duplicate result.

Screenshots:

Screenshot 2023-03-06 at 2 01 25 PM
github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-8108 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 1 year ago

:x: You don't have permission to export this issue.