magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.32k forks source link

[Issue] Chore: Bundle - Replace Block Escaping with Escaper #37101

Open m2-assistant[bot] opened 1 year ago

m2-assistant[bot] commented 1 year ago

This issue is automatically created based on existing pull request: magento/magento2#37088: Chore: Bundle - Replace Block Escaping with Escaper


Description (*)

Refactors the Magento_Bundle module to replace $block escaping functions with $escaper escaping functions.

Contribution checklist (*)

m2-assistant[bot] commented 1 year ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 1 year ago

Hello @pykettk,

Thanks for the reporting and collaboration!

We have looked into the codebase of the 2.4-develop branch and find that the function escapeJs of lib/internal/Magento/Framework/View/Element/AbstractBlock.php is marked as deprecated and from now on, should use the function defined in class lib/internal/Magento/Framework/Escaper.php named escapeJs.

Hence confirming this issue.

Thanks

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-8197 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.