[Issue] Chore: Contact - Replace Block Escaping with Escaper

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.54k stars 9.32k forks source link

[Issue] Chore: Contact - Replace Block Escaping with Escaper #37112

Open m2-assistant[bot] opened 1 year ago

m2-assistant[bot] commented 1 year ago

This issue is automatically created based on existing pull request: magento/magento2#37077: Chore: Contact - Replace Block Escaping with Escaper

Description (*)

Refactors the Magento_Contact module to replace $block escaping functions with $escaper escaping functions.

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[x] All automated tests passed successfully (all builds are green)

engcom-Bravo commented 1 year ago

Hello @pykettk,

Thanks for the reporting and collaboration!

We have looked into the codebase of the 2.4-develop branch and find that the function escapeJs of lib/internal/Magento/Framework/View/Element/AbstractBlock.php is marked as deprecated and from now on, should use the function defined in class lib/internal/Magento/Framework/Escaper.php named escapeJs.

Hence confirming this issue.

Thanks

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-8171 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.