magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.58k stars 9.32k forks source link

Wrong behavior for out-of-stock configurable products #37209

Open cptX opened 1 year ago

cptX commented 1 year ago

Preconditions and environment

Steps to reproduce

Create a configurable product with some children. Then set one child as out of stock. In Magento 2.4.6 the out of stock item will have a diagonal line on the selector. In 2.4.5 there was a bug and no line was visible, but in 2.4.6 it's corrected. The expected behavior should be to be able to select the striked-through selector, the image to change but to write Out Of Stock instead of In Stock. If this would be possible the customer also has the chance to request an email notification for the out of stock product. Now this is impossible, as he cannot select the out of stock product at all.

UPDATE: I discovered another wrong behavior which I mention here https://github.com/magento/magento2/issues/37357 . I suggest the people who will try to solve these issues to study them together with the hope to solve them as a whole and not partially...

Expected result

The correct behavior should be:

  1. To be able to click on the striked-through selector.
  2. The striked-through selector after being selected should update the image of the product shown, giving the change to the customer to see how this option/selection looks like. Now is impossible the customer to view the out of stock product.
  3. The In Stock/Out of Stock label should be updated to "Out of stock" when an striked-through option/selection gets selected.
  4. The email notification should be available for the option/selection that is out of stock. Now it's not available at all.

Actual result

Now we have the following problems:

  1. It's impossible to click on a striked-through selector.
  2. The striked-through selector after being selected is not updating the image of the product shown, so the customer has no chance to see how this option/selection looks like.
  3. The In Stock/Out of Stock label is not updated to "Out of stock" when a striked-through option/selection gets selected.
  4. The email notification is not even available on a configurable product that is out of stock. So there is no chance for the customer to get notified when a out-of-stock configurable product gets back to stock.

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 year ago

Hi @cptX. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 1 year ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

chernenm commented 1 year ago

Hello @cptX,

Thank you for reporting this. This looks like a new feature request to me rather than an issue.

cptX commented 1 year ago

Hi @chernenm, I don't have the chance to know what was the previous behavior. My first version with Magento was 2.4.5 and there to my surprise strike-through was not even working. To me is a bug as it doesn't allow you to get email notifications. I really don't understand how other people are happy with the existing behavior... How can a customer see the out-of-stock item and be prepared to buy it when back in stock if 1. we don't show him the item and 2. he cannot get notified for it?

engcom-November commented 1 year ago

Hi @cptX , Verified the issue on both Magento 2.4-develop and 2.4.6 instances and the issue is reproducible. image Unable to select the crossed out swatch (Out of stock child product) Hence out of stock status is not displayed and image is not getting changed. Updating the description and confirming the issue. Thank you.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-8291 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

cptX commented 1 year ago

Hi @cptX , Verified the issue on both Magento 2.4-develop and 2.4.6 instances and the issue is reproducible. image Unable to select the crossed out swatch (Out of stock child product) Hence out of stock status is not displayed and image is not getting changed. Updating the description and confirming the issue. Thank you.

Also important to note is that there is no option to register for an email notification when child product is back in stock!

FadedOut commented 1 year ago

Surprised the dev team considered the cross-through as a bug as I'm pretty sure it has been like this since 2.4.0 and before, so it's intended I think, as @chernenm mentioned. But I'm definitely not complaining as I agree 100%, having the option to click on it and it show out of stock but change the image to that variation would be much better. So that will be nice to get changed.

Also important to note is that there is no option to register for an email notification when child product is back in stock!

@cptX This is also more of a feature request. I can't ever remember that being an option for variation/children products - unfortunately. So you may wish to open a 'feature request' in the feature request section of Magento (when you click create new bug it has an option to choose feature request instead) as it will get noticed quicker and maybe, hopefully, they'll implement that. I know this is not the preferred solution but if you really want the feature now (though not sure if it is compatible with the newly 2.4.6 release) you could look into something like this:

https://bsscommerce.com/magento-2-out-of-stock-notification-extension.html

It will do everything you're looking for (allowing to click the out of stock items now and also allows the customer to subscribe to out of stock variations). But I do completely agree, this exact feature should be built right in. I always wondered why there is no way to subscribe to a stock notification for the variation products (we can for simple products) and would be nice to not need an extension. (ps. I don't know how well that extension I linked above works - I don't use any extension for this feature I was simply showing a search result for this that I found, hence there are ways to get this feature now if you don't want to wait 8+ months for Magento devs to implement it, if they even do)

cptX commented 1 year ago

Guys, as a bug it would have for sure more chance to be corrected faster than declared as a feature request. So please don't insist convincing everybody that it's by design. To my eyes it's clearly a bug as this self-evident function (to view the out-of-stock product) should be profoundly available. These two functions: to view the product that is out of stock and to be able to get notification when it will be back in stock is simple and basic stuff in other frameworks. Makes no sense for magento to lack this functionality.

FadedOut commented 1 year ago

Wow ok I tried to be nice.

You clearly have no clue what the difference between a "bug" and a "feature request" means.

BUG:

A feature that is ALREADY part of the system that is not working as intended. Currently a feature that is already implemented and is BROKEN. A feature that is supposed to be working that is already coded to be part of the system.

FEATURE REQUEST:

A feature that is NOT ALREADY part of the system. A feature that is MISSING. A feature that is not yet coded to be in the system.

Like wow. First, I already agreed on both points that they should be there (and the MAGE DEVS AGREE WITH YOU about the clicking the out-of-stock swatch as a BUG....). Second, neither have BEEN IN THE SYSTEM AS FAR BACK AS I CAN REMEMBER (2.4.0 to now maybe even before 2.4.0). It doesn't matter what you think if it SHOULD BE THERE or not. It is not there. Which means it IS A FEATURE REQUEST. I get that you demand it to be there now but sorry it doesn't work like that. Go to another system then. As a comparison, WooCommerce, the largest by marketshare, does not have this "feature" built-in either (to be notified of out-of-stock for variation products - YES it does have the feature to click on the out-of-stock variation but NOT to be notified - something like SUMO Waitlist is required). You MUST use a plugin. I'm unaware of any other ecommerce store that has the feature to be notified "built-in", a plugin/extension is required. If there is GREAT, use that. But this system does NOT have that feature currently. Call it oversight, call it whatever you want, but it's NOT THERE.

Throwing a fit because you want it to be part of the system now and think it NEEDS to be doesn't solve or help anything. It just simply isn't there. Go to another system or get an extension. Or as was already said submit a feature request. Like wow smh.

Don't tag me after this because I won't reply - I'm also unsubscribing from this topic. Just ridiculous.

cptX commented 1 year ago

One question please: the In Stock/Out of Stock label on the top right is it supposed to ever change in a configurable product or always stays fixed to In Stock, because what I see is that in a configurable product never changes to Out-of-Stock. For example if you have both color and size attribute in the combination that is out-of-stock it still says in stock as I have reported this issue here: https://github.com/magento/magento2/issues/37357 Not sure if this is correlated to the current issue...

lakshmana49 commented 1 year ago

@magento I am working on this

lakshmana49 commented 1 year ago

This issue is under development by an internal team. The fix will be delivered to the mainline according to our processes once done, and the status of this issue will be updated. If there are any incomplete Pull Requests to this issue and the community code will be re-used, all original commits will be preserved.

lakshmana49 commented 1 year ago

The process of development is still ongoing. Internal team identifying the common solution for all use-cases.

cptX commented 1 year ago

@lakshmana49 Thanks for the feedback. Are you in the internal team?

lakshmana49 commented 1 year ago

@cptX Yes, I am from the internal team.