Open m2-assistant[bot] opened 1 year ago
Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branch@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure. 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.Issue: Confirmed
once verification is complete. Hello @leonhelmus,
Thanks for the report and collaboration!
We have looked into the attached PR of this issue and found that the PR is related to making improvements in the Magento codebase.
Hence confirming this issue.
Thanks
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-8346 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
This issue is automatically created based on existing pull request: magento/magento2#37197: Use constructor property promotion in module send friend graph ql
Description (*)
Replace allmost all properties with constructor property promotion in module send friend graph ql: https://stitcher.io/blog/constructor-promotion-in-php-8
Readable code
I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)