Currency symbol position is not customizable

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.56k stars 9.32k forks source link

Currency symbol position is not customizable #37280

Open ducquywp92 opened 1 year ago

ducquywp92 commented 1 year ago

Summary

Since Magento 2.4.6, Zendframework1 has been removed. We use below class to format price Magento\Framework\Currency\Data\Currency.php

On line 28 public const RIGHT = 16;

On line 139 $numberFormatter = new NumberFormatter($options['locale'], NumberFormatter::CURRENCY);

Position right value has been define, but never used. So if we using Japan locale, the output of this function alway be 円100. There is no option to move currency symbol (we expect 100円)

Examples

Proposed solution

Can we have the option to change the currency symbol position?

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @ducquywp92. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 1 year ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Hotel commented 1 year ago

Hello @ducquywp92,

Thanks for the report and collaboration!

We have gone through with the description and it seems to us a valid good-to-have feature.

Hence marking this issue as a feature request.

Thanks

akosglue commented 1 year ago

@ducquywp92 how did you solve it?

gmauro99 commented 1 year ago

@akosglue @ducquywp92

Correct scenario: Even after creating an observer and set the position symbol in \Magento\Framework\Currency::LEFT or RIGHT with setData the symbol is not moved.

This is only a temporary fix.

Just make on override of the method formatCurrency in (vendor/magento/module-directory/Model/Currency.php) at line 436 with:

        if ((array_key_exists(LocaleCurrency::CURRENCY_OPTION_DISPLAY, $options)
            && $options[LocaleCurrency::CURRENCY_OPTION_DISPLAY] === \Magento\Framework\Currency::NO_SYMBOL)) {
            $formattedCurrency = str_replace(' ', '', $formattedCurrency);
        }else if (array_key_exists('position', $options)
            && $options['position'] === \Magento\Framework\Currency::LEFT){
            $exp = explode(" ", $formattedCurrency);
            $formattedCurrency = $exp[1].' '.$exp[0];
        }else if (array_key_exists('position', $options)
            && $options['position'] === \Magento\Framework\Currency::RIGHT){
            $exp = explode(" ", $formattedCurrency);
            $formattedCurrency = $exp[0].' '.$exp[1];
         }

hieptvh18 commented 1 year ago

@akosglue @ducquywp92

Correct scenario: Even after creating an observer and set the position symbol in \Magento\Framework\Currency::LEFT or RIGHT with setData the symbol is not moved.

This is only a temporary fix.

Just make on override of the method formatCurrency in (vendor/magento/module-directory/Model/Currency.php) at line 436 with:

        if ((array_key_exists(LocaleCurrency::CURRENCY_OPTION_DISPLAY, $options)
            && $options[LocaleCurrency::CURRENCY_OPTION_DISPLAY] === \Magento\Framework\Currency::NO_SYMBOL)) {
            $formattedCurrency = str_replace(' ', '', $formattedCurrency);
        }else if (array_key_exists('position', $options)
            && $options['position'] === \Magento\Framework\Currency::LEFT){
            $exp = explode(" ", $formattedCurrency);
            $formattedCurrency = $exp[1].' '.$exp[0];
        }else if (array_key_exists('position', $options)
            && $options['position'] === \Magento\Framework\Currency::RIGHT){
            $exp = explode(" ", $formattedCurrency);
            $formattedCurrency = $exp[0].' '.$exp[1];
         }

its not working for me!

gmauro99 commented 1 year ago

@akosglue @ducquywp92 Correct scenario: Even after creating an observer and set the position symbol in \Magento\Framework\Currency::LEFT or RIGHT with setData the symbol is not moved. This is only a temporary fix. Just make on override of the method formatCurrency in (vendor/magento/module-directory/Model/Currency.php) at line 436 with:
        if ((array_key_exists(LocaleCurrency::CURRENCY_OPTION_DISPLAY, $options)
            && $options[LocaleCurrency::CURRENCY_OPTION_DISPLAY] === \Magento\Framework\Currency::NO_SYMBOL)) {
            $formattedCurrency = str_replace(' ', '', $formattedCurrency);
        }else if (array_key_exists('position', $options)
            && $options['position'] === \Magento\Framework\Currency::LEFT){
            $exp = explode(" ", $formattedCurrency);
            $formattedCurrency = $exp[1].' '.$exp[0];
        }else if (array_key_exists('position', $options)
            && $options['position'] === \Magento\Framework\Currency::RIGHT){
            $exp = explode(" ", $formattedCurrency);
            $formattedCurrency = $exp[0].' '.$exp[1];
         }
its not working for me!

have you added the observer?

hieptvh18 commented 1 year ago

@akosglue @ducquywp92 Correct scenario: Even after creating an observer and set the position symbol in \Magento\Framework\Currency::LEFT or RIGHT with setData the symbol is not moved. This is only a temporary fix. Just make on override of the method formatCurrency in (vendor/magento/module-directory/Model/Currency.php) at line 436 with:
        if ((array_key_exists(LocaleCurrency::CURRENCY_OPTION_DISPLAY, $options)
            && $options[LocaleCurrency::CURRENCY_OPTION_DISPLAY] === \Magento\Framework\Currency::NO_SYMBOL)) {
            $formattedCurrency = str_replace(' ', '', $formattedCurrency);
        }else if (array_key_exists('position', $options)
            && $options['position'] === \Magento\Framework\Currency::LEFT){
            $exp = explode(" ", $formattedCurrency);
            $formattedCurrency = $exp[1].' '.$exp[0];
        }else if (array_key_exists('position', $options)
            && $options['position'] === \Magento\Framework\Currency::RIGHT){
            $exp = explode(" ", $formattedCurrency);
            $formattedCurrency = $exp[0].' '.$exp[1];
         }
its not working for me!
have you added the observer?

yes, i have added observer!

esteban-w commented 7 months ago

I came across this issue while working on a feature, and as stated previously here (https://github.com/magento/magento2/issues/37280#issuecomment-1694432544), even if you create an observer to set the currency symbol 'position' data, the symbol is not affected because the 'position' data is never taken into account in the core currency format methods. Also, the method formatCurrency in "vendor/magento/module-directory/Model/Currency.php" mentioned here too (https://github.com/magento/magento2/issues/37280#issuecomment-1694432544), is a private method, which makes the option of creating a plugin for such a method impossible.

There is however a viable option that I used to solve this issue for the feature I was working on, which involves an after-plugin for the public method formatTxt in "vendor/magento/module-directory/Model/Currency.php". In fact, I created a very lightweight module publicly available that serves as a solution, so for anyone who has come across this same issue, you are very welcome to use that module or explore it to implement a similar solution https://github.com/esteban-w/m2-currency-symbol-position (at least until we get a permanent solution implemented by Magento in a future update). The solution implemented in the module basically consists of:

The creation of a configuration option under “Admin > Stores > Configuration > General > Currency Setup > Currency Options” to define if the currency symbol should render to the right, as left is the default. This gives great flexibility because you can set this config. for the store view scope, website scope or default global scope.
An after-plugin for the formatTxt method that retrieves the current value of the currency symbol position config. mentioned above, and only if that symbol config. value has been set to render right, the currency string is formatted accordingly.

I hope this helps anyone looking for a solution, and if you need the details of my implementation you can find it at https://github.com/esteban-w/m2-currency-symbol-position

Peace.