2.4.5 EE quote total collector collect billing address totals

[alexmtch]

Preconditions and environment

• Magento version : 2.4.5 EE
• Anything else that would help a developer reproduce the bug

Steps to reproduce

Add a product to cart using a graphql request

Expected result

Billing address should not be used to collect totals

Actual result

Billing address is to collect totals and because it's a billing, it's totals will always return no charges which is a waste of execution time.

Additional information

In vendor/magento/module-quote/Model/Quote/TotalsCollector.php collect method

Why foreach ($quote->getAllAddresses() as $address) { ?

Using $quote->getAllAddresses() will return all adresses including billing. In this case why the billing is usefull to collect totals ?

We could not use here $quote->getAllShippingAddresses() ?

We can see in the bellow example there is 2 executions of collectAddressTotals (one for my billing and one for my shipping). It could optimise the add to cart process to make this changes.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [X] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @alexmtch. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9195 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[engcom-November]

Hello @alexmtch,

Thank you for reporting and collaboration.

We have tried to reproduce this on 2.4-develop. The issue seem to be reproduible when debugging app/code/Magento/Quote/Model/Quote/TotalsCollector.php

Please refer the screenshots below: Here we can see the $quote->getAllAddresses() method is collecting totals from billing address which amounts to 0.

Here it is collecting the totals from shipping address.

Hence confirming the issue.

Thanks.