Commit for B2B-2404 causes issues with GraphQL Product Data Provider

[pmzandbergen]

Summary

Starting from version 2.4.6 the Product Data Provider filters on the Visibility, this is not always desired (depending on the resolver). See commit: https://github.com/magento/magento2/commit/8681d30d2517a47baba01be70dc08031a0ab2671#diff-f94c66fe63952d9bf9efbd6d9cb69ddcb479df56dde42b9d9327a7bf4a9446abR137

File: https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/Deferred/Product.php#L138

Filtering (in this case on Visibility) is (in my opinion) something which should be handled by the Resolver, not the Data Provider.

Examples

There are multiple resolvers in 3rd party modules using the Product Data Provider. These modules expect the products to be returned, no matter their visibility. Please note that disabled or unassigned products is another story, those are expected to be filtered.

Proposed solution

Review if the filtering is desired and if so, move it to the Resolver.

Additional Information

For further commentary on this issue, this also impacts bundled products.

If you add a simple product that is visiblity - IN_CATALOG_ONLY that is not in any category on the site, then this will cause the product node of the BundleItemOption to return null since the underlying join is done against catalog_category_product_index_storeX which will not contain products if they are not assigned to any category.

This is not expected behavior because there may be a product that you want to sell as part of a bundle that isn't a part of any specific category since there's no need to list it anywhere.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @pmzandbergen. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[joanhe]

@pmzandbergen This change is done for fixing bugs causing by over fetching ignoring context. Do you see any use case that has conflict with this change? If so, please add to the issue report, so we can evaluate it.

[ananth-iyer]

Hi @joanhe on line 139, it is causing a major issue. I am getting grouped product and its child products by GraphQL. It returns grouped product details but child products are empty.

This conflicts with all GraphQL API and grouped products that add product node.

Tagging @pmzandbergen

Issue on Magento 2.4.6 and 2.4.6-p1 PHP 8.1

https://github.com/magento/magento2/blob/ca30c47787db932b9431e42226bb918e95c932d9/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/Deferred/Product.php#L134-L141

On line 139, if you change the parameter from true to false then it returns all child product properly.

Please check this again.

[ananth-iyer]

@engcom-Hotel tagging for visibility

[ananth-iyer]

@engcom-Dash

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @pmzandbergen, Thank you for report and collaboration! Thank you @ananth-iyer for your input!

We have tried to reproduce this issue on 2.4-develop CE and B2B. We are getting expected results. Please take a look at the screenshot below: We are able to get the child product properly from the below query.

{
  products(filter:{
    url_key:{
      eq:"a-bag1"
    }
  }) {
    items {
      url_key
      sku
         price_range {
             minimum_price {
                    final_price {
                      value
                      currency
                    }

              discount {
                percent_off
                amount_off
              }

              regular_price {
                value
                currency
              }

                  }

                  maximum_price {
                    final_price {
                      value
                      currency
                    }
                    regular_price {
                      value
                      currency
                    }
                    discount {
                      percent_off
                      amount_off
                    }
                  }
        }
   ... on GroupedProduct {
       items {
           position
           qty
           product {
               uid
               sku
               name
               only_x_left_in_stock
               price_range {
                   maximum_price {
                       final_price {
                           currency
                           value
                       }
                       regular_price {
                           currency
                           value
                       }
                   }
                   minimum_price {
                       final_price {
                           currency
                           value
                       }
                       regular_price {
                           currency
                           value
                       }
                   }
               }
           }
       }
   }

    }
  }
}

Please let us know if we are missing something.

Thank you.

[pmzandbergen]

We have tried to reproduce this issue on 2.4-develop CE and B2B. We are getting expected results.

That is correct, on a native Magento installation you will get the expected results. Please see the original description: "Filtering (in this case on Visibility) is (in my opinion) something which should be handled by the Resolver, not the Data Provider."

Its more a discussion about resolvers VS providers. Changing the behavior of the provider affected some 3rd party modules, since they didn't expect the provider to apply additional filters on its own. Isn't that something which should be handled by the resolver?

[engcom-November]

Hello @pmzandbergen,

Thank you for your quick response!

As the issue is not present in the core-magento library, but some 3rd party modules, please let us know in which modules you are getting the issue, this will help us to dig deep into the issue.

Thank you.

[pmzandbergen]

@engcom-November please have a look at the comment from @ananth-iyer: https://github.com/magento/magento2/issues/37405#issuecomment-1649827128

It seems this change does cause issues in the Magento core (did you test it with the child products being invisible but enabled?). Even if it didn't the original issue shouldn't be fixed by changing the Data Provider in my opinion.

• Resolver: Its task is to resolve data, for example: "The first 100 products with the price between X and Y ordered by price" or "All child products for grouped product XYZ"
• Data Provider: Convert the (to be) resolved products based on the requested attributes (depending on the GraphQL query)

With this change its the Data Provider applying filters, thats not its role (except for, maybe, filtering disabled products).

[engcom-November]

Hello @pmzandbergen,

Thank you for the response, and we agree with your point https://github.com/magento/magento2/issues/37405#issuecomment-1698600535.

Resolver should add filters and not data provider, but as we can see here data provider is applying the filter. Hence this issue can be confirmed.

Thank you.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10849 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[damienwebdev]

For further commentary on this issue, this also impacts bundled products.

If you add a simple product that is visiblity - IN_CATALOG_ONLY that is not in any category on the site, then this will cause the product node of the BundleItemOption to return null since the underlying join is done against catalog_category_product_index_storeX which will not contain products if they are not assigned to any category.

This is not expected behavior because there may be a product that you want to sell as part of a bundle that isn't a part of any specific category since there's no need to list it anywhere.

[engcom-Hotel]

Thanks @pmzandbergen for more information on this. We have added the same in Additional Information of the main description.