PageBuilder rendering slowly after Chrome version 112

paturiku-p commented 1 year ago

Preconditions and environment

Magento version: 2.4.2-p2, also tested on 2.4.5-p2 and 2.4.6
PageBuilder is enabled
Chrome 112 and newer
CMS page with pagebuilder content

Steps to reproduce

Use Chrome version 112 or above
Edit CMS Page, Product or anything that has PageBuilder.
Try saving. It takes a long time 20+ seconds (a lot longer than on older versions or in other browsers)

Expected result

Content is saved as quickly as in other browsers, or older versions of Chrome.

Actual result

PageBuilder takes a long time to render. PageBuilder is rendering slowly to master template (when content is saved), only on Chrome version 112 and newer.

Additional information

Also there is an error in console: [ERROR] Page Builder was rendering for 5 seconds without releasing locks.

I have a suspicion that the applyBindings function in magento/module-page-builder/view/adminhtml/web/js/master-format/render.js takes too long to complete.

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[X] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @paturiku-p. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

paturiku-p commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @paturiku-p. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @paturiku-p, here is your Magento Instance: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering Admin access: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering/admin_500e Login: 929458d6 Password: 886ed71d50a8

paturiku-p commented 1 year ago

Issue confirmed on develop instance:

On firefox I can save page instantly, but on Chrome it takes a long time.

Chrome version 112.0.5615.165:

engcom-Dash commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash, here is your Magento Instance: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering Admin access: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering/admin_0a5c Login: 0ae7f480 Password: 755b12f2ec16

engcom-Dash commented 1 year ago

Hi @paturiku-p ,

Verified the issue in 2.4-develop instance and the issue is not reproducible.Kindly refer the below screenshots.

Steps to reproduce: 1.Install magento instance 2.Go to CMS page or product and edit with page builder 3.Save

We got error in console even-though Pages or product saved successfully both chrome and Firefox browsers and we are using latest version.

Let us know if we are missing anything!

paturiku-p commented 1 year ago

Hi @engcom-Dash

thank you for checking the issue, the issue is that it takes considerably longer time to save any PageBuilder content on 112+ version of chrome than on other browsers, or older versions of chrome. On firefox I don't get the error that "PageBuilder was rendering for 5 seconds without releasing locks.", the problem isn't that it is impossible to save entities, but the slowdown after updating Chrome. I believe it is caused by some 'optimization' in Chrome and it makes the work of content creators a lot more tedious.

paturiku-p commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @paturiku-p. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @paturiku-p, here is your Magento Instance: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering Admin access: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering/admin_c7e0 Login: a873071f Password: 2cb44b616114

engcom-Dash commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash, here is your Magento Instance: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering Admin access: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering/admin_488b Login: 737e4b56 Password: 5b723cf33bbc

engcom-Dash commented 1 year ago

Hi @paturiku-p ,

Thanks for contribution and collaboration! verified the issue in 2.4-develop instance and the issue is not reproducible,Kindly recheck the behaviour in 2.4-develop instance.

Kindly refer the below video reference:

https://github.com/magento/magento2/assets/60198592/b1d2675f-4716-46b9-90a7-255d570d12e4

We are trying to save the page-builder with some modifications with latest chrome version of 114 and its saved successfully.

Kindly recheck the behaviour in 2.4-develop instance and let me know if we are missing anything!

Thanks.

0franco commented 1 year ago

Same issue here, just adding more info

Randomly save fast but most of the time is so slow ~10/20 seconds
Chrome version: Version 114.0.5735.106 (Official Build) (arm64)
If you can't reproduce it try saving several times same block/page or edit the content adding random widgets
No reproducible on my end on Safari v16.5

engcom-Dash commented 1 year ago

Hi @paturiku-p ,

We are trying to reproduce the issue in 2.4-develop instance and we are not able to reproduce.Are you still want more investigation kindly let us know.

Thanks.

engcom-Dash commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash, here is your Magento Instance: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering Admin access: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering/admin_fb27 Login: f3ff684e Password: 192335bf27d7

paturiku-p commented 1 year ago

Hi @engcom-Dash

Hi @paturiku-p ,

We are trying to reproduce the issue in 2.4-develop instance and we are not able to reproduce.Are you still want more investigation kindly let us know.

Thanks.

The issue still remains, altho we also reported it on Magento Commerce and they are looking into it. Last update was from 4 days ago saying that dev team is investigating the issue :)

chittima commented 1 year ago

I was able to reproduce the issue. Click on Edit with Page Builder and save, try couple of times, issue is reproducible. Internal team is working on this issue.

engcom-Dash commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Dash, here is your Magento Instance: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering Admin access: https://6f48b650463be9351e9265d994f53b8e.instances-prod.magento-community.engineering/admin_895f Login: dd5a13ff Password: 06102d671e44

engcom-Dash commented 1 year ago

Hi @paturiku-p

Verified the issue in 2.4-develop instance and the issue is reproducible.

Kindly refer the screenshots:

We are getting Actual result which page builder taking time to render on first time and we got console error as per the description.

Note: This is not happening frequently, it may occurs some time only.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9044 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 1 year ago

:x: You don't have permission to export this issue.

github-jira-sync-bot commented 1 year ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-9044

hostep commented 1 year ago

@engcom-Dash, @chittima: any info why this ticket got closed?

chittima commented 1 year ago

Hi @hostep Issue was fixed by Internal team

hostep commented 1 year ago

@chittima: can you please post the associated commits, so people who want the fix can try to patch it themselves? Thanks! (please never close issues without leaving feedback and add links to the commits that fixed it, I've been complaining for the last 3 years about this and it still happens, is quite annoying that this still happens, @sdzhepa, @sidolov ...)

chittima commented 1 year ago

Hi @hostep here is the commit id https://github.com/magento/magento2-page-builder/commit/69953bcb7f1ac3a793ec7e0b09fc07e680a80856

magento / magento2