Unable to checkout with braintree in multishipping with disabled vault for card payments.

bosskar231 commented 1 year ago

Summary

Preconditions and environment Upon upgrading our production site from M2.4.3-p2 to M2.4.6 we discovered customers were unable to checkout multishipping via Credit Card using the Braintree Payments extension V4.5.0 bundled in to M2.4.6 The cause was found to be the Enable Vault for Card Payments disabled on the Braintree.

Steps to reproduce Fresh Install of M2.4.6 in environment as above Login to backend

Nav to Admin>Stores>Configure>Sales>Payment Methods Select Merchant Country as United States and Save Config Configure Braintree Payments (by GENE Commerce v4.5.0) Enter known valid sandbox credentials for Merchant ID, Public Key, Private Key and Validate Credentials Disable Card Payments = Yes and Save Config Flush Magento Cache

On Frontend, successfully Sign In using Demo Customer Access credentials Add any product to cart Proceed to Checkout with multiple addresses Shipping Method select Fixed Flat Rate Payment Method select Credit Card Enter Card # 4111 1111 1111 1111 Expiration: 12/2023 Security Code: 123 Click blue "Place Order" button on review order page Observe "spinner" appears for a moment and then automatically redirects to Payment page with the error as Order Page Error.

Expected result: Order should placed successfully

Actual result: Getting error like "Order place error"

Examples

In previous Magento version 2.4.3-p1 Customer can place an multishipping order with the disabled vault for card payments option in braintree. But in latest 2.4.6 version . It seems they make it mandatory to enable the value for card payments option to make multishipping checkout.

Proposed solution

With the new approach to enable the vault for card payments for multishipping it also affects the normal checkout flow .Braintree is storing credit card details for normal checkout and placing an order in admin. Is it possible to revert back or could you please provide a patch.

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @bosskar231. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Dash commented 1 year ago

Hi @bosskar231 ,

Thanks for contribution and collaboration ! Verified the issue in 2.4.6 magento instance and the issue is reproducible in 2.4.6 magento instance,Hence we are confirming the issue.

Preconditions: magento version 2.4.6 PHP 8.1

Steps to reproduce:

[ ] Install magento instance
[ ] Setup Braintree Payment configuration in Backend
[ ] Disable Card Payments = Yes and Save Config
[ ] Checkout through Multi-shipping with credit card payment

Kindly refer the screenshots: 2.4.3-p2

2.4.6 instance

Magento version 2.4.3-p2 Customer can place multi-shipping order with the disabled vault for card payments option in Braintree. But in latest 2.4.6 version . It seems mandatory to enable the value for card payments option to make multi-shipping checkout.

github-jira-sync-bot commented 1 year ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 1 year ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9006 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 1 year ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-9006

bosskar231 commented 1 year ago

Hi, Any update on this.

bosskar231 commented 1 year ago

Hi, Any update on this. Can we get a patch.

magento / magento2