Call to a member function getTypeId() on bool

[sannam-wesco]

Preconditions and environment

• Magento version: 2.4.5-p1
• Execute Graphql Mutation from Postman

Steps to reproduce

1. Requisition Lists, addProductsToRequisitionList → Add a valid SKU that is not isVisibleInCatalog
2. What is happening: a. \Magento\RequisitionList\Model\RequisitionListProduct::getProduct will return false b. \Magento\GroupedRequisitionList\Plugin\Model\RequisitionListItem\SaveHandler::aroundSaveItem will try to access the product getTypeId property. But since product is false, the process crashes.

Expected result

1. it should not report as an error back in response "report.ERROR: Call to a member function getTypeId()".

Actual result

1. Getting error as "report.ERROR: Call to a member function getTypeId() on bool"

Additional information

No response

Release note

No response

Triage and priority

• [X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @sannam-wesco. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[Adward345]

The error message "Call to a member function getTypeId() on boo" typically indicates that you are trying to invoke the getTypeId() method on a variable or object that is not of the expected type or does not have that method defined.

The error message suggests that the variable or object in question is of type "boo" instead of the expected type. It's important to ensure that you are working with the correct object or variable and that it has the necessary methods defined.

To troubleshoot this issue, you can follow these steps:

Check the variable or object: Verify the variable or object you are trying to invoke the getTypeId() method on. Make sure it is the correct object and that it is instantiated properly.

Review the object's definition: Examine the class or object definition to ensure that the getTypeId() method is actually defined within that class. Check for any typos through viptools-apk or incorrect method names.

[engcom-Bravo]

@Adward345 Thanks for your contribution & collaboration over here.

Hi @sannam-wesco,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

• Requisition Lists, addProductsToRequisitionList → Add a valid SKU that is not isVisibleInCatalog

We have created a product with visibility as Not Visible Individually

We are not getting any error in the response.

Kindly recheck the behaviour on Magento 2.4-develop instance with EE edition and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

[sannam-wesco]

@engcom-Bravo

Issue is still exist.

Steps to reproduce

1. in Magento Admin side. go to products -> Edit any product and disable the product. to make it inVisibleInCatalog to No
2. Go to postman and try to add that product to requisition list.
3. it is throwing the error

Expected behaviour:

1. it should not throw an error. and should display message somthing like "The SKU was not found."

I checked in Magento EE Eidtion.

The culprit is in "vendor\magento\module-requisition-list\Model\RequisitionListProduct.php" file in getProduct($sku) function is returning false, if product is not visible in catalog. But in "vendor\magento\module-grouped-requisition-list\Plugin\Model\RequisitionListItem\SaveHandler.php" $parentProduct = $this->requisitionListProduct->getProduct((string)$productData->getSku()); if ($parentProduct->getTypeId() !== Grouped::TYPE_CODE) // This line trying to get Type Id on false.

[engcom-Bravo]

Hi @sannam-wesco,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance with ee edition and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

• in Magento Admin side. go to products -> Edit any product and disable the product. to make it inVisibleInCatalog to No
• Go to postman and try to add that product to requisition list.

We have disabled the product Simple.

We are getting as The SKU was not found.

Kindly recheck the behaviour on Magento 2.4-develop instance with EE edition and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

[engcom-Bravo]

Hi @sannam-wesco,

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.