magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.47k stars 9.28k forks source link

Category issue : load disable category at page builder's component category drop-down #37646

Open alpesh2689 opened 1 year ago

alpesh2689 commented 1 year ago

Preconditions and environment

Steps to reproduce

In the above snap that disable category also loaded.

Expected result

If Admin disabled any category from Catalog -> Categories then it should not be visible OR listed in the page builder's any component related to category dropdown.

Actual result

If Admin disabled any category from Catalog -> Categories then it is visible OR listed at the page builder's component related to the category dropdown

Additional information

Suppose we need to load the top category list at the home page using the page builder at that time any category disable ( If Admin disabled any category from Catalog -> Categories then it is visible OR listed at the page builder's component related to the category dropdown )

So that category link redirects to 404

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 year ago

Hi @alpesh2689. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

alpesh2689 commented 1 year ago

@magento I am working on this

m2-assistant[bot] commented 1 year ago

Hi @alpesh2689! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

alpesh2689 commented 1 year ago

@magento add to contributors team

m2-assistant[bot] commented 1 year ago

Hi @alpesh2689! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

alpesh2689 commented 1 year ago

@magento I am working on this

engcom-Bravo commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo, here is your Magento Instance: https://a54a8472a767cc4d14b1e6c40f0be231.instances-prod.magento-community.engineering Admin access: https://a54a8472a767cc4d14b1e6c40f0be231.instances-prod.magento-community.engineering/admin_167e Login: db26ad98 Password: 8cb921749a31

engcom-Bravo commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo, here is your Magento Instance: https://a54a8472a767cc4d14b1e6c40f0be231.instances-prod.magento-community.engineering Admin access: https://a54a8472a767cc4d14b1e6c40f0be231.instances-prod.magento-community.engineering/admin_0c5b Login: 396b7810 Password: 455477d3eded

engcom-Bravo commented 1 year ago

Hi @alpesh2689,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the attached screenshots.

Steps to reproduce

We have disabled category JACKETS from Mens>Tops.In frontend it is not showing and it is working fine.

Screenshot 2023-06-22 at 12 17 33 PM

While editing the content using pagebuilder category JACKETS is still showing in the category tree even it is disabled.

Screenshot 2023-06-22 at 12 21 10 PM

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9052 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

craigfleming commented 1 year ago

Many merchants who use Page Builder product carousel or grid content type would argue that this is not an issue, but a desirable feature. Allowing users to choose disabled categories within Page Builder provides a simple way to collate best-selling or high-stock products to show on the front end of any Magento website without having to choose from a long list of product SKU's. It helps to streamline a workflow for merchandising products on any Magento system.

@engcom-Bravo - This is a step backwards for Magento Page Builder. My vote would be to close this issue as it's not an issue at all but a way for @alpesh2689 to make an easy pull request into an Open Source project for his CV.

alpesh2689 commented 1 year ago

@craigfleming Thank you for your comment on the reported issue regarding the Magento 2 Page Builder. However, I would like to clarify some details to ensure a better understanding of the situation.

I want to clarify that the intention behind reporting this issue is to improve the functionality and user experience of the Page Builder, not for personal gain or to enhance my CV. The issue has been reported based on real experiences faced while working with the feature. As per the below Image, it allows to add link of disabled categories too which leads to a 404 page when the content is created. This behavior is causing inconvenience and potential usability issues for users.

image

While your comment suggests that this might be intended functionality or a feature rather than an issue, I would like to emphasize that the ability to select a disabled category in the Page Builder is resulting in broken links and poor user experience. It is important to ensure that the Page Builder only allows the selection of active and valid categories to prevent such issues.

If you have any further insights or information regarding this matter, I would appreciate your input. However, if you believe that this behavior is indeed intended and not an issue, kindly provide more context or guidelines to help us understand the reasoning behind it.

Thank you for your attention to this matter, and I look forward to further discussions and resolution.

@engcom-Bravo Thanks for confirming the issue after seeing it in detail.