sampledata:reset has no effect since Magento 2.3.0

schmengler commented 1 year ago

Preconditions and environment

With Magento 2.3.0, the sample data modules were changed to work with data patches instead of legacy data upgrade scripts. But the reset command still assumes a data_version of the module which is not used anymore:

            foreach (array_keys($sampleDataPackages) as $name) {
                $moduleName = $this->packageInfo->getModuleName($name);
                if ($moduleName !== null) {
                    $this->moduleResource->setDataVersion($moduleName, '');
                }
            }

Steps to reproduce

run bin/magento sampledata:deploy
run bin/magento sampledata:reset

Expected result

patches from sample data modules are removed from patch_list database table

Actual result

no change

Additional information

No response

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @schmengler. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 1 year ago

Hi @schmengler,

Thank you for reporting and collaboration.

As per Magento devdocs https://experienceleague.adobe.com/docs/commerce-operations/installation-guide/next-steps/sample-data/remove-or-update.html?lang=en#prepare-to-update-sample-data the bin/magento sampledata:reset command enables you to update sample data.

Could you please refer the document and please let us know if we are missing anything.

Thanks.

schmengler commented 1 year ago

@engcom-Bravo I see no issue with that documentation. I assume it is still correct that this command should be used before updating. However, this is not the only purpose. If we look at the output of bin/magento help sampledata:reset, it says "Reset all sample data modules for re-installation"

Description:
  Reset all sample data modules for re-installation

Usage:
  sampledata:reset

Options:
  -h, --help            Display this help message
  -q, --quiet           Do not output any message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

For proper reinstallation, the DB entries for data patches must be removed so that they will be re-applied again to create products etc.

To clarify again: Currently, the command does nothing

engcom-Bravo commented 1 year ago

Hi @schmengler,

Thanks for your update.

We are considering this as a feature request to proceed further as this as a existing behaviour of Magento.

Thanks.

schmengler commented 1 year ago

@engcom-Bravo in this case, I would request to delete the paragraph of the documentation, because - I repeat - the command currently does nothing.

magento / magento2