Inconsistent payment_method field length in grid tables

[mjresurs]

Preconditions and environment

On Magento 2.4.6 it appears that the column payment_method has inconsistent lengths in the different grid tables which results in the payment method not showing in the grid views in admin.

Table	Length
sales_order_grid	255
sales_invoice_grid	128
sales_creditmemo_grid	32
sales_shipment_grid	32

Steps to reproduce

1. Create or modify a payment method so that its code is longer than 32 characters.
2. Place an order using that payment method
3. Create an order shipment
4. Show the Payment Method column in the shipment grid view

Expected result

The payment method name is displayed in the Payment Method column in the grid view.

Actual result

The Payment Method name column is blank.

Additional information

No response

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @mjresurs. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, here is your Magento Instance: https://ef1e021ad17f870cd00eca7730517f22.instances-prod.magento-community.engineering Admin access: https://ef1e021ad17f870cd00eca7730517f22.instances-prod.magento-community.engineering/admin_b0b7 Login: 31b14b9d Password: 8ca5e99a1891

[engcom-Bravo]

Hi @mjresurs,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

• Create or modify a payment method so that its code is longer than 32 characters.
• Place an order using that payment method
• Create an order shipment
• Show the Payment Method column in the shipment grid view

The payment method name is displayed in the Payment Method column in the grid view after shipment.

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

[mjresurs]

@engcom-Bravo I'm not sure if there was some miscommunication here but it appears your screenshot shows payment methods with long names rather than a long code. The issue I've noticed on 2.4.6 is that you can have a payment method with a code like, as an example, custom_module_payment_method_code_that_is_quite_long (52 characters).

Now what happens when you create a credit memo or shipment is that Magento will store this as the truncated 32 character string custom_module_payment_method_cod in since that's the max length of the column payment_method is in both sales_creditmemo_grid and sales_shipment_grid.

So when you then try to view the credit memo or shipment grids it will fail to fetch the payment method information because there is no payment method with the code custom_module_payment_method_cod.

[mjresurs]

E.g. for the table sales_shipment_grid in /app/code/Magento/Sales/etc/db_schema.xml#L786:

<column xsi:type="varchar" name="payment_method" nullable="true" length="32" comment="Payment Method"/>

[m2-assistant[bot]]

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @mjresurs,

Thanks for the report & collaboration!

We have tried to reproduce the issue in Magento 2.4-develop branch by looking into the codebase. And it seems the issue is valid.

When we are creating a shipment and if the code exceeds the limit i.e. 32, then the code will either be truncated or empty. Hence confirming the issue.

Thanks

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9114 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.