magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

[Issue] Fix missing jQuery widget dependency #37683

Closed m2-assistant[bot] closed 1 year ago

m2-assistant[bot] commented 1 year ago

This issue is automatically created based on existing pull request: magento/magento2#37302: Fix missing jQuery widget dependency


Description (*)

When the JS bundling is enabled, and the trim input js file isn't in the bundle, on the 1st page-view we're getting JS error caused by missing $.widget function.

image
bundle-common.min.js:1 TypeError: $.widget is not a function
    at trim-input.min.js:1:46
    at Object.execCb (require.min.js:117:195)
    at i.execCb (bundle-common.min.js:1:525685)
    at Module.check (require.min.js:59:418)
    at Module.enable (require.min.js:77:285)
    at Module.init (require.min.js:57:144)
    at callGetModule (require.min.js:78:238)
    at Object.completeLoad (require.min.js:110:1)
    at HTMLScriptElement.onScriptLoad (require.min.js:117:393)

My Pull Request fixes this issue by declaring a missing dependency to jquery widget.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9115 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.