module-sales/Model/Order/Creditmemo/Total/Tax.php division by 0 on line 139 and 140

[Naberdz]

Preconditions and environment

• Magento version 2.4.6 Custom shipping method with 0 costs.

Steps to reproduce

Create order and choose delivery method with 0 costs. Complete order and click on creditmemo button. you will get error

Expected result

Creditmemo should be working

Actual result

We get error.

had to replace those lines with the following:

139                 $part = $creditmemo->getShippingAmount() / ($orderShippingAmount != 0 ? $orderShippingAmount :  1);
140                 $basePart = $creditmemo->getBaseShippingAmount() / ($baseOrderShippingAmount !=0 ? $baseOrderShippingAmount : 1);

Additional information

No response

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @Naberdz. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, here is your Magento Instance: https://82ff5428c157a16b7ac2d70bf4c4447a.instances-prod.magento-community.engineering Admin access: https://82ff5428c157a16b7ac2d70bf4c4447a.instances-prod.magento-community.engineering/admin_d1c4 Login: b6cedd99 Password: bc3d1696060c

[engcom-Bravo]

Hi @Naberdz,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

• Create order and choose delivery method with 0 costs.
• Complete order and click on creditmemo button.

We are able to create the credit memo for the order having $0 shipping method.

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

[engcom-Bravo]

Hi @Naberdz,

Kindly provide latest update on this comment https://github.com/magento/magento2/issues/37686#issuecomment-1614203759 if you are able to reproduce the issue please elaborate steps to reproduce if the issue is still reproducible.

Thanks.

[dudzio12]

There is a problem in isShippingIncludeTaxWithTaxAfterDiscount() method, which returns true here: https://github.com/magento/magento2/blob/ca30c47787db932b9431e42226bb918e95c932d9/app/code/Magento/Sales/Model/Order/Creditmemo/Total/Tax.php#L137

Then it runs the $part = $creditmemo->getShippingAmount() / $orderShippingAmount;, where $orderShippingAmount can be 0 at this point.

Actually there is a fix already for this issue in this commit: https://github.com/magento/magento2/commit/d32646fd5f04cc7f5a2bf4d1f73b110a78197d83

Those changes implements checking if $orderShippingAmount > 0 and runs that part of the code only if it's true.

[engcom-Bravo]

@dudzio12 Thanks for your contribution & collaboration over here.

Hi @Naberdz,

This issue has been fixed under this commit d32646f Hence we are closing this issue.

Thanks.