product view validation.js undefined this.radioCheckboxClosest

[sheepfy]

https://github.com/magento/magento2/blame/2abc466714ec397efbe865ac1f10b7141aa586f3/app/code/Magento/Catalog/view/frontend/web/product/view/validation.js#L45

This line will be always undefined since the jquery.validate.js got updated to the latest version.

jquery.validate.js is now doing: this.settings.errorPlacement.call( this, place, $( element ) ); instead of: this.settings.errorPlacement( place, $( element ) );

Therefor in product/view/validation.js "this" variable is changed and this.radioCheckboxClosest is not defined. It needs to be updated to "this.settings.radioCheckboxClosest"

[m2-assistant[bot]]

Hi @sheepfy. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[sheepfy]

cc @magento-engcom-team

[sheepfy]

Also after fixing this issue, when clicking "add to cart" button first time, highlight errors will appear, which is good. But if you click second time the "add to cart" button, the error option will get removed.

[sheepfy]

Added test in vanila magento, configurable product with extra custom options of type checkbox (replicable also for radios)

[sheepfy]

If using the correct selector in there:

First click: Second click:

[m2-assistant[bot]]

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @sheepfy,

Thanks for the report and collaboration!

We have tried to reproduce the issue in the 2.4-develop branch and it seems the issue is reproducible as mentioned in the description.

Please have a look at the below screenshot for reference:

Hence confirming the issue.

Thanks

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9121 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.