Venia Sample Data error with php 8.2

ximenez commented 1 year ago

Preconditions and environment

Magento version: Adobe Commerce 2.4.6-p1
Install Venia Sample Data "composer require magento/venia-sample-data:*"
bin/magento setup:upgrade

Steps to reproduce

Adobe Commerce 2.4.6-p1 with PHP 8.2
Install Venia Sample Data "composer require magento/venia-sample-data:*"
Deployment error in cloud: Deprecated Functionality: Creation of dynamic property Magento\CmsSampleDataVenia\Model\Block\Converter::$eavConfig is deprecated in /app/vendor/magento/module-cms-sample-data-venia/Model/Block/Converter.php on line 66

Expected result

Venia Sample DAta works with PHP 8.2.

Actual result

Error: Deprecated Functionality: Creation of dynamic property Magento\CmsSampleDataVenia\Model\Block\Converter::$eavConfig is deprecated in /app/vendor/magento/module-cms-sample-data-venia/Model/Block/Converter.php on line 66

Additional information

Fis should add $eavConfig property to block

/**
 * @var \Magento\Eav\Model\Config
 */
protected $eavConfig;

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @ximenez. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Dash commented 1 year ago

Hi @ximenez ,

Verified the issue in 2.4-develop instance and the issue is not reproducible. Steps to reproduce: 1.Install magento instance 2.Deploy sample data for composer instllation as per DevDocs 3.Run setup upgrade command Kindly refer the below screenshots:

Sample data installed successfully

Thanks

ximenez commented 1 year ago

@engcom-Dash Issue is with "Venia Sample Data", not with Standard Sample Data.

engcom-Dash commented 1 year ago

Hi @ximenez ,

Verified the issue in 2.4.6-p1 adobe commerce and the issue is reproducible,Hence we are confirming the issue. Kindly refer the below screenshot:

Thanks.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9163 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

hostep commented 1 year ago

Is possibly already fixed by https://github.com/PMET-public/module-venia-cms-sample-data/commit/471542cf359a01a5c34db1e04e646ce2be10ed65, but no idea if that is the official module on github, or just some clone, also no idea if a new version was created containing this fix (the commit mentions version 0.0.4, but no idea if it's published yet on repo.magento.com)

Just FYI...

magento / magento2