magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Depreciated USPS Shipping methods; new USPS Ground Advantage method #37742

Closed Abbey-Lubber closed 1 year ago

Abbey-Lubber commented 1 year ago

Preconditions and environment

Magento 2.4.6-p1 Sample Data

Steps to reproduce

  1. Setup USPS shipping methods such as 'USPS First-Class Package', 'USPS Retail Ground' or 'USPS Parcel Select' in Stores->Configuration->Sales->Delivery Methods->USPS->Allowed Methods.
  2. Add product (under 1lb product weight ) to cart on frontend.
  3. Estimate shipping costs.

Expected result

Shipping prices for all available shipping methods are displayed.

Actual result

Shipping methods are not visible due to the fact that these shipping methods have been depreciated by USPS on July 9, 2023

https://faq.usps.com/s/article/USPS-Ground-Advantage

The new shipping method, USPS Ground Advantage, does not appear in the list of 'allowed shipping methods' and cannot be used.

*relative newbie creating this bug report...

image

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 year ago

Hi @Abbey-Lubber. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 1 year ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


FadedOut commented 1 year ago

Wow this is a pretty big issue. Did USPS not give a heads up or did Magento drop the ball again?

Either way hopefully someone has a way to work in the new shipping methods as USPS is used by many many merchants (and customers) and waiting 6+ months for two releases from now would not be good...

Abbey-Lubber commented 1 year ago

I got notifications from USPS and Pirateship the last week of June about the coming changes... I just assumed someone here had gotten the same notifications and patched it until I lost functionality on the 9th.... Looks like they are working on it though...

FadedOut commented 1 year ago

Oh yeah, I just checked and you're right, Pirateship did send out a notice - but I didn't even notice the notice lol. Well, let's hope they really are working on it because my customers will be complaining soon I'm sure as USPS is used here and there.

engcom-Dash commented 1 year ago

Hi @Abbey-Lubber ,

Verified the issue in 2.4-develop instance and the issue is reproducible,Hence we are confirming the issue. Magento version 2.4-develop PHP version8.1

Steps to reproduce: 1.Install magento instance 2.Go to Stores->Configuration->Sales->Delivery Methods->USPS->Allowed Methods 3.Select new shipping method "USPS Ground Advantage"

Kindly refer the below video reference:

https://github.com/magento/magento2/assets/60198592/59fa67a5-b716-4142-bd1f-1c2de8a0ef73

The new shipping method "USPS Ground Advantage" does not appear in the list of 'allowed shipping methods'.

Thanks

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9139 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

swonton23 commented 1 year ago

We are trying to find a solution. Please share if anyone has the fix?

FadedOut commented 1 year ago

@swonton23 thankfully it looks like @Franciscof-Serfe is working on a PR as mentioned earlier in this ticket. Also, from that same page, it is mentioned (with a USPS pdf as source) that we have a grace period of up to Sep 30, 2023. So, we can keep using the available shipping methods listed in Magento for now and USPS will accept the packages even if they are the old ship methods.

But again, thankfully someone other than Magento devs are working on it because if we had to wait on them we'd all be screwed - at this point this will probably be April 2024 to be fixed "officially" in the Magento base. They always fix things two or more versions later. It's awful. IDK how the "Adobe Commerce" patching is with something like this but if this wasn't fixed immediately, I'd be cancelling my $20k+/mo subscription so quick. IDK how any pays that with such terrible delays in fixes. WooCommerce is also free and fixes things like this in one week. /ugh I digress...

Abbey-Lubber commented 1 year ago

Just a clarification on the grace period: USPS will not generate labels or provide rate quotes for the deprecated shipping methods. They will only "Accept, process and deliver" these shipping services. As of July 9th, 2023, 'First Class Package, Parcel Select Ground and Ground Returns' do not show on the website frontend and cannot be selected by customers. This is literally the least expensive shipping method available in the USA and the most common shipping method chosen on my website... Again, I appreciate @Franciscof-Serfe working on this...

Franciscof-Serfe commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @Franciscof-Serfe, here is your Magento Instance: https://c2af19c9aaa7585e1ed0f37dfc05b660.instances-prod.magento-community.engineering Admin access: https://c2af19c9aaa7585e1ed0f37dfc05b660.instances-prod.magento-community.engineering/admin_06fc Login: be375334 Password: e102b4363660

Franciscof-Serfe commented 1 year ago

@magento I am working on this

m2-assistant[bot] commented 1 year ago

Hi @Franciscof-Serfe! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

Franciscof-Serfe commented 1 year ago

@magento add to contributors team

m2-assistant[bot] commented 1 year ago

Hi @Franciscof-Serfe! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

Franciscof-Serfe commented 1 year ago

@magento add to contributors team @magento I am working on this

DMC-15 commented 1 year ago

@Franciscof-Serfe Thanks for helping out on this!

FadedOut commented 1 year ago

@Abbey-Lubber

Just a clarification on the grace period: USPS will not generate labels or provide rate quotes for the deprecated shipping methods. They will only "Accept, process and deliver" these shipping services. As of July 9th, 2023, 'First Class Package, Parcel Select Ground and Ground Returns' do not show on the website frontend and cannot be selected by customers.

Wow it's even worse than I thought. Unbelievable. This makes me very nervous to be using Magento for my business with barely an official response to this situation...

bbatten commented 1 year ago

@Franciscof-Serfe Thanks for helping out on this!

Do you have any updates on a solution? Do you know when we can expect a fix?

Abbey-Lubber commented 1 year ago

@esteban-serfe has provided working patches in the pull request (#37745) above. Most of @Franciscof-Serfe's patches have been reverted. Manually patched on my website and appears to be working beautifully!

DMC-15 commented 1 year ago

@Abbey-Lubber are the patches fully functional yet? It looks like some checks are still being ran.

Franciscof-Serfe commented 1 year ago

Hello everyone, I wanted to share some good news. The issue with USPS shipping methods has been successfully resolved in pull request #37745

You can find the validation in this comment: https://github.com/magento/magento2/pull/37745#issuecomment-1646083016 of what the test instance showed.

Currently, we are finishing the final adjustments to the test results to complete the process. Best regards, Francisco

DMC-15 commented 1 year ago

@Franciscof-Serfe Great news indeed! Thank you for all your help and hard work! I'll let my developers know.

Franciscof-Serfe commented 1 year ago

Hi @engcom-Dash @ihor-sviziev , Can you relate this issue with PR #37745? I have not found what command I should pass to the bot to do it or if there is one that can run as a collaborator.

Thank you so much!

engcom-Bravo commented 1 year ago

Hi @Abbey-Lubber,

Thank you for reporting and collaboration.

"Team has started processing this PR #37745 internally after testing all possible scenarios."

Thanks.

Franciscof-Serfe commented 1 year ago

@magento give me 2.4.4-p5 instance

magento-deployment-service[bot] commented 1 year ago

Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @Franciscof-Serfe, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Franciscof-Serfe commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @Franciscof-Serfe, here is your Magento Instance: https://c2af19c9aaa7585e1ed0f37dfc05b660.instances-prod.magento-community.engineering Admin access: https://c2af19c9aaa7585e1ed0f37dfc05b660.instances-prod.magento-community.engineering/admin_a7ae Login: 7b667687 Password: 417e7bb7c4a9

chernenm commented 1 year ago

A hotfix for this issue for all 2.4.4, 2.4.5 and 2.4.6 versions has been released recently https://experienceleague.adobe.com/docs/commerce-knowledge-base/kb/troubleshooting/known-issues-patches-attached/usps-ground-advantage-shipping-method-support-hotfix-for-ac-9182.html