[2.4.5-p3] [GraphQL] Applied discounts not returned for virtual carts

[DuckThom]

Preconditions and environment

• Magento version 2.4.5-p3
• Cart consists only of virtual products (is_virtual is true)
• Cart has coupon code applied

Steps to reproduce

1. Create an empty cart
2. Add virtual product to the cart
3. Apply coupon code to cart
4. Retrieve the cart with the applied discounts

query cart($cartId: String!) {
    cart(cart_id: $cartId) {
        is_virtual
        prices {
            discounts {
                amount {
                    value
                    currency
                }
                label
            }
        }
        applied_coupons {
            code
        }
    }
}

Expected result

Coupon is applied to the cart and the applied discount is visible in the cart.prices.discounts array.

{
  is_virtual: true,
  prices: {
    discounts: [
      { amount: { value: 159.8, currency: 'EUR' }, label: '20% Discount' }
    ]
  },
  applied_coupons: [ { code: 'TEST-123' } ]
}

Actual result

Coupon code is applied and the discount is subtracted from the order total, however, the cart.prices.discounts field is null

{
  is_virtual: true,
  prices: {
    discounts: null
  },
  applied_coupons: [ { code: 'TEST-123' } ]
}

Additional information

https://github.com/magento/magento2/blob/ca30c47787db932b9431e42226bb918e95c932d9/app/code/Magento/QuoteGraphQl/Model/Resolver/Discounts.php#L45

The Discounts resolver attempts to read the discounts from the cart shipping address. Since it's a virtual cart, there is no shipping address and therefor no discounts will be returned.

Potential fix Changing the line to $address = $quote->getBillingAddress(); will return the discounts as expected. But I am not sure if this will be 100% reliable.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @DuckThom. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, here is your Magento Instance: https://7108b5f85a79b56ea3e7305a62bfbf5f.instances-prod.magento-community.engineering Admin access: https://7108b5f85a79b56ea3e7305a62bfbf5f.instances-prod.magento-community.engineering/admin_2634 Login: 7e2978d8 Password: 17963ab68801

[engcom-Bravo]

Hi @DuckThom,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

• Create an empty cart
• Add virtual product to the cart
• Retrieve the cart with the applied discounts

query cart($cartId: String!) {
    cart(cart_id: $cartId) {
        is_virtual
        prices {
            discounts {
                amount {
                    value
                    currency
                }
                label
            }
        }
        applied_coupons {
            code
        }
    }
}

As per this document https://developer.adobe.com/commerce/webapi/graphql/schema/cart/queries/cart/#cartprices-object we will get the discounts under discounts object.Please refer the document and let us know if you are still facing any issue.

Thanks.

[DuckThom]

Hello @engcom-Bravo

I am able to reproduce this on the 2.4-develop branch.

I've created a clean Magento 2 installation, with 1 virtual product and 1 cart price rule (20% discount) with a coupon code "TEST-123"

After which I've executed the following GraphQL mutations:

1. Create an empty cart:

2. Added the product to the cart

3. Applied the coupon code

As you can see in the final screenshot, the coupon code is applied, but the cart.prices.discounts field is empty

[DuckThom]

Additionally, here is a screenshot of the cart query of the current situation:

As you can see, the 20% discount itself is applied (grand total is 10 EUR lower than the subtotal). But there is no active discount listed in the response.

Here is a screenshot of the response (query is the same as above) where I applied the potential fix I mentioned in my original comment:

Here, the applied discount amount of 20% / 10 EUR is correctly visible in the response.

[engcom-Bravo]

Hi @DuckThom,

Thanks for your quick response.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible. Kindly refer the screenshots.

Steps to reproduce

• Create an empty cart
• Add virtual product to the cart
• Retrieve the cart with the applied discounts

query cart($cartId: String!) {
    cart(cart_id: $cartId) {
        is_virtual
        prices {
            discounts {
                amount {
                    value
                    currency
                }
                label
            }
        }
        applied_coupons {
            code
        }
    }
}

Coupon is getting applied but in the discounts field we are getting as NULL.

Hence Confirming this issue.

Thanks.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9169 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[duncan16101994]

any update?