Bundle Product - Ship Separately - Order Status Complete

[timpea-splat]

Preconditions and environment

• Magento version 2.4.6-p1 & dev-develop

Steps to reproduce

1. Create Bundle Product

2. Add more than 1 bundled product

3. Set: Ship Bundle Items - Separately

4. Create order for bundle product, selecting more than 1 product

5. Invoice order

6. Ship part of the bundled order

Expected result

Order Status: Processing

Actual result

Order Status: Complete

Additional information

No response

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [x] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @timpea-splat. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, here is your Magento Instance: https://ea446b48c9a2de103056de856381954d.instances-prod.magento-community.engineering Admin access: https://ea446b48c9a2de103056de856381954d.instances-prod.magento-community.engineering/admin_ba3c Login: 23a0da70 Password: fae82e1e9a60

[engcom-Bravo]

Hi @timpea-splat,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

• Create Bundle Product
• Add more than 1 bundled product
• Set: Ship Bundle Items - Separately
• Create order for bundle product, selecting more than 1 product
• Invoice order
• Ship part of the bundled order

After doing partial shipment of the order the order should be in Processing status but it is in Complete status.

Hence Confirming the issue.

Additionally Tested:

It is working fine for other types of products and orders for partial shipments.

Thanks.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9198 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[Vikaashkarthick-K]

@magento I am working on this

[jsamhall]

Hi @Vikaashkarthick-K have you identified the cause for this? We are seeking to patch as this issue is preventing us from deploying our latest application built on 2.4.6 -- Thank you!

[jsamhall]

We believe this bug was introduced by the following commit:

https://github.com/magento/magento2/commit/7d680387d1341319dbf10f3f914f363f2dea81d8#diff-c8d66fa5975f0f5940ac131e828f9b7bd742603d7fcbe236b036a305525e4008

Specifically, in the implementation of isPartiallyRefundedOrderShipped

The logical fault is comparing the value of total_qty_ordered against values derived from iterating over getAllItems() wherein the former will only be inclusive of parent items (or simple products) and the latter will be inclusive of child products.

We use "Ship Bundle Items Separately" so I am more familiar with this logical flow, so the above may not be accurate for your use case.

Our temporary workaround has been to introduced an Around plugin which effectively reverts the changes to vendor/magento/module-sales/Model/ResourceModel/Order/Handler/State.php back to its functionality in 2.4.5 which works for us. The bug that the commit seeks to address is much less severe to us than an inability to partially ship Bundle orders, as this is an extremely common use case for our business.

[shahbaztariq]

@Vikaashkarthick-K @jsamhall this is fixed in quality patch ACSD-57003

https://github.com/magento/quality-patches/blob/master/patches/os/ACSD-57003_2.4.6-p3.patch