Open sebfie opened 1 year ago
Hi @sebfie. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release@magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
@magento give me 2.4-develop instance
Hi @sebfie. Thank you for your request. I'm working on Magento instance for you.
Hi @sebfie, here is your Magento Instance: https://28563f023e0a53d166d47241ae85e176.instances-prod.magento-community.engineering Admin access: https://28563f023e0a53d166d47241ae85e176.instances-prod.magento-community.engineering/admin_e1ca Login: a6d378c2 Password: 80d102304c24
Hello, can I have a feedback? It seems critical, it's about prices...
Any update?
Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branch@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure. 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.Issue: Confirmed
once verification is complete. Hi @sebfie,
Thank you for reporting and collaboration.
Verified the issue on Magento 2.4-develop instance.Kindly refer the screenshots.
Steps to reproduce
bin/magento indexer:reindex" is doing the work as per expectations(removing product from the table "catalogrule_product_price" when product is out of stock and adding the product in the table when it's in stock again) is there any specific reason to use the "n98-magerun2 sys:cron:run indexer_update_all_views" command.
Could you please let us know if we are missing anything.
Thanks.
Hello,
thank you for your answer.
!!! I made a terrible mistake writing my issue, the issue is on table catalog_product_index_price
and not catalogrule_product_price
!!!!
I updated my initial post
Hi @sebfie,
Thanks for your update.
We have verified the issue for the table catalog_product_index_price and the issue is not reproducible.
product stock to 0
product removed from table
product in stock
executed n90.magerun2 , product not added
executed default command, it worked
Could you please let us know the default "bin/magento indexer:reindex" is doing the work as per expectations(removing product from the table "catalog_product_index_price" when product is out of stock and adding the product in the table when it's in stock again) .is there any specific reason to use the "n98-magerun2 sys:cron:run indexer_update_all_views" command?
Thanks.
Hello,
Is your product id 5?
bin/magento indexer:reindex
is doing the job but it's not what we are expecting using async/partiel reindex. The issue comes in partial reindex, not full. If you set the product out_of_stock with 0, and let cron reindex this "partial" reindex, you will see the product not disappearing from catalog_product_index_price
You should not run bin/magento indexer:reindex
beetween checks. Just let cron reindex.
So it heppens when :
n98-magerun2 sys:cron:run indexer_update_all_views
to not run cron:run
but I think it does the samecatalog_product_index_price
Hi @sebfie,
Thanks for your update.
Verified the issue on Magento 2.4-develop instance and the issue is reproducible.The issue is reproducible with partial reindexing,
Here product id is 2 not disappearing after doing Partial Reindexing.
Hence Confirming the issue.
Thanks.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9496 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Thx a lot. I refered the commit I think responsible of that. Take a look :
https://github.com/magento/magento2/commit/b3969936251e1a03427cd24c209abb6af3a0ce1b
Duplicate of #35616 which was closed unresolved ❤️ with some incredible information about how to reproduce and comment how to fix it https://github.com/magento/magento2/issues/35616#issuecomment-1196320526
Ok but it should be revolted in develop branch no?
Thank you
Preconditions and environment
Steps to reproduce
cataloginventory/options/show_out_of_stock
is set to 0 (default value)catalog_product_price_cl
bin/magento indexer:set-mode schedule
n98-magerun2 sys:cron:run indexer_update_all_views
=>catalog_product_index_price
are not removed for this productcatalog_product_index_price
for this productin_stock
and a stock of 8 then save it => catalog_product_price_cl is not populated so partial reindex will not fillcatalog_product_index_price
tablen98-magerun2 sys:cron:run indexer_update_all_views
=>catalog_product_index_price
is not filled by this productExpected result
We expect to fill/remove from catalog_product_index_price when a product switch from out_of_stock and in_stock. The main issue is that there is not trigger to insert the concerning product in
catalog_product_price_cl
when thecataloginventory_stock_item
changeActual result
Product data are missing/disappear from
catalog_product_index_price
Additional information
The issue comes from this commit :
https://github.com/magento/magento2/commit/b3969936251e1a03427cd24c209abb6af3a0ce1b
Triggers are not well created on
cataloginventory_stock_item
to fill the tablecatalog_product_price_cl
when stock change.Release note
No response
Triage and priority