catalog_product_price is not populated with products when back in stock

[sebfie]

Preconditions and environment

• 2.4.6-p1
• With sample data

Steps to reproduce

1. Create a Magento 2.4.6-p1 instance
2. Install sample data
3. Check core_config_data cataloginventory/options/show_out_of_stock is set to 0 (default value)
4. Take a product without related/crosssell/upsell products (no catalog_product_link). !!!! IMPORTANT !!!! because this products will trigger an insert in catalog_product_price_cl
5. Set indexer as scheduled bin/magento indexer:set-mode schedule
6. Set product from Adminhtml as out_of_stock with a stock of 0 and save => the product is not removed from catalog_product_index_price and catalog_product_price_cl is not populated
7. Run n98-magerun2 sys:cron:run indexer_update_all_views => catalog_product_index_price are not removed for this product
8. Remove lines from catalog_product_index_price for this product
9. Set product with in_stock and a stock of 8 then save it => catalog_product_price_cl is not populated so partial reindex will not fill catalog_product_index_price table
10. Run n98-magerun2 sys:cron:run indexer_update_all_views => catalog_product_index_price is not filled by this product

Expected result

We expect to fill/remove from catalog_product_index_price when a product switch from out_of_stock and in_stock. The main issue is that there is not trigger to insert the concerning product in catalog_product_price_cl when the cataloginventory_stock_item change

Actual result

Product data are missing/disappear from catalog_product_index_price

Additional information

The issue comes from this commit :

https://github.com/magento/magento2/commit/b3969936251e1a03427cd24c209abb6af3a0ce1b

Triggers are not well created on cataloginventory_stock_item to fill the table catalog_product_price_cl when stock change.

Release note

No response

Triage and priority

• [X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @sebfie. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[sebfie]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @sebfie. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @sebfie, here is your Magento Instance: https://28563f023e0a53d166d47241ae85e176.instances-prod.magento-community.engineering Admin access: https://28563f023e0a53d166d47241ae85e176.instances-prod.magento-community.engineering/admin_e1ca Login: a6d378c2 Password: 80d102304c24

[sebfie]

Hello, can I have a feedback? It seems critical, it's about prices...

[alitopaloglu]

Any update?

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @sebfie,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance.Kindly refer the screenshots.

Steps to reproduce

• Create a Magento 2.4.6-p1 instance
• Install sample data
• Check core_config_data cataloginventory/options/show_out_of_stock is set to 0 (default value)
• Take a product without related/crosssell/upsell products (no catalog_product_link). !!!! IMPORTANT !!!! because this products will trigger an insert in catalog_product_price_cl
• Set indexer as scheduled bin/magento indexer:set-mode schedule
• Set product from Adminhtml as out_of_stock with a stock of 0 and save => the product is not removed from catalogrule_product_price and catalog_product_price_cl is not populated
• Run n98-magerun2 sys:cron:run indexer_update_all_views => catalogrule_product_price are not removed for this product
• Remove lines from catalogrule_product_price for this product
• Set product with in_stock and a stock of 8 then save it => catalog_product_price_cl is not populated so partial reindex will not fill catalogrule_product_price table
• Run n98-magerun2 sys:cron:run indexer_update_all_views => catalogrule_product_price is not filled by this product

bin/magento indexer:reindex" is doing the work as per expectations(removing product from the table "catalogrule_product_price" when product is out of stock and adding the product in the table when it's in stock again) is there any specific reason to use the "n98-magerun2 sys:cron:run indexer_update_all_views" command.

Could you please let us know if we are missing anything.

Thanks.

[sebfie]

Hello,

thank you for your answer.

!!! I made a terrible mistake writing my issue, the issue is on table catalog_product_index_price and not catalogrule_product_price !!!!

I updated my initial post

[engcom-Bravo]

Hi @sebfie,

Thanks for your update.

We have verified the issue for the table catalog_product_index_price and the issue is not reproducible.

product stock to 0

product removed from table

product in stock

executed n90.magerun2 , product not added

executed default command, it worked

Could you please let us know the default "bin/magento indexer:reindex" is doing the work as per expectations(removing product from the table "catalog_product_index_price" when product is out of stock and adding the product in the table when it's in stock again) .is there any specific reason to use the "n98-magerun2 sys:cron:run indexer_update_all_views" command?

Thanks.

[sebfie]

Hello,

Is your product id 5?

• Yes bin/magento indexer:reindex is doing the job but it's not what we are expecting using async/partiel reindex. The issue comes in partial reindex, not full. If you set the product out_of_stock with 0, and let cron reindex this "partial" reindex, you will see the product not disappearing from catalog_product_index_price

You should not run bin/magento indexer:reindex beetween checks. Just let cron reindex.

So it heppens when :

• scheduled reindex is enabled
• Switch product when in_stock to out_of_stock (product is enqueued to be reindexed)
• Run partial reindex => That's why I used n98-magerun2 sys:cron:run indexer_update_all_views to not run cron:run but I think it does the same
• Product does not disappear from catalog_product_index_price

[engcom-Bravo]

Hi @sebfie,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.The issue is reproducible with partial reindexing,

• scheduled reindex is enabled
• Switch product when in_stock to out_of_stock
• Run partial reindex => n98-magerun2 sys:cron:run indexer_update_all_views
• Product does not disappear from catalog_product_index_price
• Switch product out_of_stock to in_stock
• Run partial reindex => n98-magerun2 sys:cron:run indexer_update_all_views
• Product does not reappear to catalog_product_index_price

Here product id is 2 not disappearing after doing Partial Reindexing.

Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9496 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[sebfie]

Thx a lot. I refered the commit I think responsible of that. Take a look :

https://github.com/magento/magento2/commit/b3969936251e1a03427cd24c209abb6af3a0ce1b

[nkajic]

Duplicate of #35616 which was closed unresolved ❤️ with some incredible information about how to reproduce and comment how to fix it https://github.com/magento/magento2/issues/35616#issuecomment-1196320526

[sebfie]

Ok but it should be revolted in develop branch no?

Thank you