magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

PageBuilder save very slow in Chrome #37798

Open quanghien95 opened 1 year ago

quanghien95 commented 1 year ago

Preconditions and environment

Steps to reproduce

  1. Use Chrome version 112 or above
  2. Edit CMS Page, Product or anything that has PageBuilder.
  3. Save page. It takes very long time or save or loading forever. JS file is loading from the networks instead of browser cache, so that saving is very slow

Expected result

The content saving quickly. JS file should getting from browser cache

Actual result

JS files always loading from the networks. The content saving very slow. Sometime its stuck forever.

Additional information

I see that the issue happen when page builder rendering in iframe. Some js file is always loading from networks instead of browser cached. So that we have to spent more time to wait until all js file is loading correct. Sometime, when network is slow. The spin loading forever and the content is not save and we will lost the current work.

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 year ago

Hi @quanghien95. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

quanghien95 commented 1 year ago

@magento give me 2.4-develop instance @magento I am working on this

m2-assistant[bot] commented 1 year ago

Hi @quanghien95! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

magento-deployment-service[bot] commented 1 year ago

Hi @quanghien95. Thank you for your request. I'm working on Magento instance for you.

quanghien95 commented 1 year ago

@magento add to contributors team

m2-assistant[bot] commented 1 year ago

Hi @quanghien95! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

quanghien95 commented 1 year ago

@magento I am working on this

magento-deployment-service[bot] commented 1 year ago

Hi @quanghien95, here is your Magento Instance: https://8353e8bc8e57c177a2a4efdd8a8311c0.instances-prod.magento-community.engineering Admin access: https://8353e8bc8e57c177a2a4efdd8a8311c0.instances-prod.magento-community.engineering/admin_03ff Login: 048492ed Password: 49e0615a5aca

hostep commented 1 year ago

Sounds like a duplicate of https://github.com/magento/magento2/issues/37516 ?

This might fix your issue: https://github.com/magento/magento2/issues/37516#issuecomment-1634682775

Let us know if that did the trick? And then close this ticket. Thanks! 🙂

quanghien95 commented 1 year ago

@hostep Thanks for your information. I read this issue #37516. But its not fix my issue. These js file always loading from networks instead of browser cache when page builder open. In case slow network. It can take very long time to save the cms content. Let me update the issue description for more clear.

I can reproduce this issue in current 2.4-develop instance Please kindly check this video screenshot:

https://github.com/magento/magento2/assets/11818221/7287fb9a-1072-4b7d-9b5d-e3be95d1145b

quanghien95 commented 1 year ago

This Is the PR to fixing this issue: https://github.com/magento/magento2-page-builder/pull/854

norgeindian commented 1 year ago

@quanghien95 , I included the fix, but unfortunately it did not change anything for me. The page still needs 30 secs to save. But I actually have the problem on product pages. Does that make a difference?

quanghien95 commented 1 year ago

@norgeindian This should be the same. You also need to apply this patch and patch #37516 together. Check the network and make sure that some js file is loading correct from browser cache instead of from networks

norgeindian commented 1 year ago

@quanghien95 , thanks for the clarification. With both patches together, it actually works. Thanks a lot for the fix.

thanhndmagento commented 1 year ago

Thank you! It works for me. The PageBuilder was very slow before

m2-assistant[bot] commented 1 year ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Delta commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Delta, here is your Magento Instance: https://8353e8bc8e57c177a2a4efdd8a8311c0.instances-prod.magento-community.engineering Admin access: https://8353e8bc8e57c177a2a4efdd8a8311c0.instances-prod.magento-community.engineering/admin_9084 Login: a9d13d49 Password: d399921bd2be

engcom-Delta commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Delta, here is your Magento Instance: https://8353e8bc8e57c177a2a4efdd8a8311c0.instances-prod.magento-community.engineering Admin access: https://8353e8bc8e57c177a2a4efdd8a8311c0.instances-prod.magento-community.engineering/admin_2528 Login: c0622b1b Password: 97687a0c0897

engcom-Delta commented 1 year ago

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Issue occurs when page builder rendering in iframe. Some js file is always loading from networks instead of browser cached.

1   Using Chrome version 112 or above
2   Edit CMS Page, Product or anything that has PageBuilder.
3   Save page. It takes very long time or save or loading forever.
JS file is loading from the networks instead of browser cache, so that saving is very slow

Attaching recording

https://github.com/magento/magento2/assets/51681379/3e917996-8492-4b8f-b159-b6ead65fae21

and screenshot

<img width="1435" alt="Screenshot 2023-09-15 at 3 00 56 PM" src="https://github.com/magento/magento2/assets/51681379/91ebbfa3-ed8c-4089-9747-ea3422ab9c82">

Hence Confirming the issue.

github-jira-sync-bot commented 1 year ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 1 year ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9567 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.