magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.48k stars 9.29k forks source link

[Issue] Fix variable name in catalogsearch #37810

Open m2-assistant[bot] opened 1 year ago

m2-assistant[bot] commented 1 year ago

This issue is automatically created based on existing pull request: magento/magento2#33533: Fix variable name in catalogsearch


Fix variable name, the search engine has nothing to do with a default country. PR Update: I've removed the unneccessary variable. Thanks for the idea @tzyganu ;-)

Description (*)

It's a bit strange and confusing to use a variable called $defaultCountry in the search engine module. I've renamed removed the variable, there's no change in the behavior/logic of the method.

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

Change Search Engine in the magento admin panel: Stores > Settings > Configuration > Catalog > Catalog > Catalog Search

Contribution checklist (*)

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9215 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.