Bug Report: Existing Image Name removed when image added via api

brideo commented 1 year ago

Preconditions and environment

Magento version 2.4.6
Rest API

Steps to reproduce

POST https://exmple.com/rest/V1/products/some-sku/media

{ "entry": { "position": 9999, "media_type": "image", "label": "Some Product Label", "disabled": false, "types": [ "image", "thumbnail", "small_image" ], "file": "1234.jpeg", "content": { "base64_encoded_data": "image_data", "type": "image\/jpeg", "name": "1001110080394.jpeg" } } }

Expected result

Image is added

Actual result

Image is added with no name assigned.

Additional information

Replace the existing code within Magento\Catalog\Model\Product\Gallery\GalleryManagement::create:

// Existing code snippet
$product = $this->productInterfaceFactory->create();
$product->setSku($sku);
$product->setMediaGalleryEntries($existingMediaGalleryEntries);
try {
    $product = $this->productRepository->save($product);
} catch (\Exception $e) {
    if ($e instanceof InputException) {
        throw $e;
    } else {
        throw new StateException(__("The product can't be saved."));
    }
}

with

// Corrected code snippet
$product = $this->productRepository->get($sku);
$product->setMediaGalleryEntries($existingMediaGalleryEntries);
try {
    $product = $this->productRepository->save($product);
} catch (\Exception $e) {
    if ($e instanceof InputException) {
        throw $e;
    } else {
        throw new StateException(__("The product can't be saved."));
    }
}

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @brideo. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

brideo commented 1 year ago

https://github.com/magento/magento2/pull/37836 - fixed and created a PR here

m2-assistant[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo, here is your Magento Instance: https://e57249666a8a1edd856c4d4b991e2333.instances-prod.magento-community.engineering Admin access: https://e57249666a8a1edd856c4d4b991e2333.instances-prod.magento-community.engineering/admin_9d5f Login: c4d6f8f3 Password: 0278c3d85036

engcom-Bravo commented 1 year ago

Hi @brideo,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

{ "entry": { "position": 9999, "media_type": "image", "label": "Some Product Label", "disabled": false, "types": [ "image", "thumbnail", "small_image" ], "file": "1234.jpeg", "content": { "base64_encoded_data": "image_data", "type": "image\/jpeg", "name": "1001110080394.jpeg" } } }

We have added image via REST API(name as Magento) and we are getting image name also could you please let us know if we are missing anything and also provide screenshots where exactly image name will be populated it will helps us to reproduce the issue.

Thanks.

brideo commented 1 year ago

when you send images it removes the name attribute.

https://patch-diff.githubusercontent.com/raw/magento/magento2/pull/37836.patch

See how before it creates an empty object, assigns an a sku, adds images then saves it?

engcom-Bravo commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 1 year ago

Hi @engcom-Bravo, here is your Magento Instance: https://e57249666a8a1edd856c4d4b991e2333.instances-prod.magento-community.engineering Admin access: https://e57249666a8a1edd856c4d4b991e2333.instances-prod.magento-community.engineering/admin_4c59 Login: 23c951ec Password: f6f323258dbb

engcom-Bravo commented 1 year ago

Hi @brideo,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

We have send the images using API

After sending the images we are able to get the name attribute.

kindly let us know still if we are missing anything.Please provide screenshots if possible it will help us to proceed further.

Could you please elaborate the steps to reproduce regarding this comment https://github.com/magento/magento2/issues/37835#issuecomment-1676553454

Thanks.

engcom-Bravo commented 1 year ago

Hi @brideo,

Kindly provide latest update on this comment https://github.com/magento/magento2/issues/37835#issuecomment-1682195010 still you are working on this issue if you are able to reproduce the issue please elaborate the steps to reproduce.Please let us know still if you are facing any issue.

Thanks.

engcom-Bravo commented 1 year ago

Hi @brideo,

We have noticed that this issue has not been updated since long time. Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

brideo commented 1 month ago

hi @engcom-Bravo - I am still seeing this on 2.4.7-p2 but my patch is no longer working, how do I get a develop instance?

magento / magento2