[Issue] Ensure Quote::collectTotals() correctly handles recursion

[m2-assistant[bot]]

This issue is automatically created based on existing pull request: magento/magento2#36475: Ensure Quote::collectTotals() correctly handles recursion

---

Description

We have written a plug-in for a shipping method. Our plugin requires access the quote object to perform its business logic. We get a reference to the current quote object by calling Magento\Checkout\Model\Session::getQuote(). This works correctly and we get a reference to the quote object and can perform the required actions.

Within Magento\Checkout\Model\Session::getQuote(), there is a call to $quote->collectTotals(). When this runs via our plug-in, Magento ends up calling $quote->collectTotals() within an existing call to $quote->collectTotals() (recursion). This becomes a problem when we introduce gift cards, which is a feature of Adobe Commerce. Because we are applying the gift cards each time $quote->collectTotals() is called, but the second time around the gift cards are already 'used', so they do not get applied to the $quote, and therefore disappear from the checkout.

Manual testing scenarios

Preconditions:

• Adobe Commerce with Gift Card Accounts feature
• Gift card with an available balance less than the total of the cart
• A plug-in within the shipping method totals collection which calls Magento\Checkout\Model\Session::getQuote()

Steps to reproduce:

1. Add items to cart to ensure cart total is more than available balance on gift card
2. Apply gift card at cart
3. Proceed to payment step in checkout
4. Notice gift card is applied correctly
5. Select payment method multiple times
6. Notice gift card is (not) applied correctly

Contribution checklist

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [x] All new or changed code is covered with unit/integration tests (if applicable)
• [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [x] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @fredden,

Thanks for the report and collaboration!

We have tried to reproduce the issue in Magento 2.4-develop branch but it seems the issue is not reproducible for us.

We have tried to follow the steps mentioned in the main description. For reference, we are attaching the plugin made by us in order to reproduce the issue. Magz.zip

We have made after plugin on Magento\Quote\Model\Quote, and for us Gift Card is applying correctly.

Gift Card

Checkout Page

Let us know in case we have missed anything.

Thanks