magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

Free shipping cart rules do not apply #37945

Closed Larke12 closed 1 year ago

Larke12 commented 1 year ago

Preconditions and environment

Steps to reproduce

  1. Setup a cart rule for all customer groups with no coupon, following the setup as denoted in the documentation.
  2. Ensure shipping methods with cost are available: Flat Rate and/or Table Rates.
  3. Add product(s) to cart that triggers the condition (i.e. If All of these conditions are True: Subtotal equals or greater than 50)
  4. Provide estimated shipping information or full shipping address, view shipping costs.

Expected result

All shipping methods with cost should show as $0.00 or on selection denote a deduction of equal value.

Actual result

No discount is applied to offer free shipping on any methods.

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 year ago

Hi @Larke12. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 1 year ago

Hi @Larke12,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

Test-Promotions-Marketing-Magento-Admin (4)

Shopping-Cart (9)

All shipping methods showing $0 as a shipping costs.

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

TiffanyElNino commented 1 year ago

@Larke12 I encountered this problem with 3rd party shipping methods, maybe it helps you as well. These custom shipping methods were setting their rate based on the comparison $request->getFreeShipping() === true, but in some responses the result of getFreeShipping() is an int(1), due to a recent cast change which results in a false expression.

engcom-Bravo commented 1 year ago

@TiffanyElNino Thanks for your contribution & collaboration over here.

Hi @TiffanyElNino,

Can you please provide latest update on this comment https://github.com/magento/magento2/issues/37945#issuecomment-1702531112 and also please check issue is causing due to any third party extensions if so please refer the solution here https://github.com/magento/magento2/issues/37945#issuecomment-1710011886.

Please let us know if you are still facing any issue.

Thanks.

engcom-Bravo commented 1 year ago

Hi @Larke12,

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

Larke12 commented 1 year ago

@TiffanyElNino Thanks for the tip! That does in fact seem to resolve the issue a client of mine was facing, though third party shipping methods were not installed in my test case.

Given that this isn't the first issue raised for this problem and the fix is reverting the core change, it seems likely that this should be revisited by someone at some point. Otherwise if people come across this a simple plugin should help overcome the bug.