In Store Delivery sources show regardless of product stock status

dtfdigital commented 1 year ago

Preconditions and environment

Magento version: 2.4.6
Anything else that would help a developer reproduce the bug:

Steps to reproduce

Create new non-default "Stock" and set the sales channel as your website.
Create 2 sources: Local, Warehouse.
Set Local source as an active pickup location and fill out the fields pertaining to this (address, latlong etc)
Assign these sources to the non-default stock.
Ensure that the distance settings / api key etc are set correctly so that pickup locations can show on the frontend.
Create a product, and assign the Local, and Warehouse sources. Set the stock level on Local as 0 (out of stock) and warehouse as 5 (in stock).
On the frontend, add the product to cart and proceed through the checkout.
Select the pick in store option.

Expected result

As the product is out of stock for the Local stock source, the store pickup location for this should not appear (or show as unavailable).

Actual result

The store pickup location for the Local stock source shows as available.

Additional information

In order to resolve the issue the product needs to be removed from the Local stock source when out of stock which negates the point of having the out of stock status on these?

Release note

No response

Triage and priority

[X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 year ago

Hi @dpdesignthatfits. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

dtfdigital commented 1 year ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 1 year ago

Hi @dpdesignthatfits. Thank you for your request. I'm working on Magento instance for you.

m2-assistant[bot] commented 1 year ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-deployment-service[bot] commented 1 year ago

Hi @dpdesignthatfits, here is your Magento Instance: https://f68cfe99b48eaa7068588a58c0553713.instances-prod.magento-community.engineering Admin access: https://f68cfe99b48eaa7068588a58c0553713.instances-prod.magento-community.engineering/admin_484e Login: 939ee968 Password: 8d47707719c0

dtfdigital commented 1 year ago

@engcom-Bravo Tested and confirmed reproducible on the develop instance. Can you add label for us?

Area: Inventory Reproduced on 2.4.x Issue: Confirmed

engcom-Bravo commented 1 year ago

Hi @dpdesignthatfits,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

Create new non-default "Stock" and set the sales channel as your website.
Create 2 sources: Local, Warehouse.
Set Local source as an active pickup location and fill out the fields pertaining to this (address, latlong etc)
Assign these sources to the non-default stock.
Ensure that the distance settings / api key etc are set correctly so that pickup locations can show on the frontend.
Create a product, and assign the Local, and Warehouse sources. Set the stock level on Local as 0 (out of stock) and warehouse as 5 (in stock).
On the frontend, add the product to cart and proceed through the checkout.
Select the pick in store option.

Since the product is in out of stock for Local source the store pickup location should not be available but still it is displaying.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 1 year ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-9561 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 year ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

devendra-nulogic commented 9 months ago

I have created a patch to fix this issue

diff --git a/vendor/magento/module-inventory-in-store-pickup/Model/ResourceModel/GetPickupLocationIntersectionForSkus.php b/vendor/magento/module-inventory-in-store-pickup/Model/ResourceModel/GetPickupLocationIntersectionForSkus.php
index 3f5e11d..d561416 100644
--- a/vendor/magento/module-inventory-in-store-pickup/Model/ResourceModel/GetPickupLocationIntersectionForSkus.php
+++ b/vendor/magento/module-inventory-in-store-pickup/Model/ResourceModel/GetPickupLocationIntersectionForSkus.php
@@ -70,6 +70,7 @@ class GetPickupLocationIntersectionForSkus
                 $this->sourceResource->getMainTable() . '.' . SourceInterface::SOURCE_CODE
             )
             ->where(SourceItemInterface::SKU . ' in (?) ', $skus)
+            ->where(SourceItemInterface::STATUS . ' = 1')
             ->where(SourceInterface::ENABLED . ' = 1')
             ->where(PickupLocationInterface::IS_PICKUP_LOCATION_ACTIVE . ' = 1')
             ->reset(Select::COLUMNS)

miller75 commented 8 months ago

Any update on this, @devendra-nulogic fix works if you only have one pickup location

magento / magento2