SELECT from media_storage_file_storage when media DB storage is not in use or disabled

[ilnytskyi]

Preconditions and environment

• Any version
• Disabled and never used media Db storage

Steps to reproduce

1. Disable and never use DB media storage
2. Make sure the table media_storage_file_storage does not exists
3. Allow nginx to fallback to pub/get.php to resolve image
4. Access non existent image e.g. https://magento.local/media/wysiwyg/someImage.jpg

Expected result

1. The code execution does not trigger queries to media_storage_file_storage table
2. The user gets placeholder image without triggering media_storage_file_storage table
3. Mysql service does not contain warning logs about accessing the table media_storage_file_storage
4. Exceptions are logged in and not silently suppressed Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize
5. Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize does not use disabled DB media storage

Actual result

1. The request triggers the queries to media_storage_file_storage table
2. Mysql service contains warning logs about accessing the table media_storage_file_storage that does not exists
3. Exceptions are not logged and silently suppressed in Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize
4. Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize does not uses disabled DB media storage

Additional information

The execution path according blackfire

PDOStatement::execute(select e.* from media_storage_file_storage as e where (filename = ?) and (directory = ?))
 Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize
 Magento\MediaStorage\App\Media\Interceptor::createLocalCopy
 Magento\MediaStorage\App\Media\Interceptor::launch
 Magento\Framework\App\Bootstrap::run
 run_init::pub/get.php

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/MediaStorage/Model/File/Storage/Synchronization.php#L57 The Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize executes a this code:

 /** @var $storage Database */
        $storage = $this->storageFactory->create();
        try {
            $storage->loadByFilename($relativeFileName);
        } catch (\Exception $e) {
        }

The workaround can be to adjust nginx config, but still the code has to be refactored, as no warnings logged, and query is fired to non-existent table.

Release note

During accessing images via pub/get.php the select queries to media_storage_file_storage are not fired when DB media storage is disabled.

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @ilnytskyi. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @ilnytskyi,

Thank you for the report and collaboration!

Can you please elaborate the 3rd step in Steps to reproduce, and it would be great if you could provide code examples and use case for the issue. This will help us to reproduce the issue more effectively.

Thank you.

[ilnytskyi]

@engcom-November You can check the message with xdebug

 /** @var $storage Database */
        $storage = $this->storageFactory->create();
        try {
            $storage->loadByFilename($relativeFileName);
        } catch (\Exception $e) {
           //here or just
          var_dump($e);
        }

On the other hand you can enable DB query logging bin/magento dev:query-log:enable or directly on DB and see that magento sends selects to media_storage_file_storage table.

[engcom-November]

Hello @ilnytskyi,

Thank you for the quick reply!

We were able to reproduce this issue on 2.4-develop. Please take a look at the screenshot below: Here we can see a query to the non-existent table media_storage_file_storage. Hence confirming the issue.

Thank you.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10586 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[github-jira-sync-bot]

:x: You don't have permission to export this issue.

[leonhelmus]

Is there already a patch available from Adobe commerce?

CC. @engcom-November

[leonhelmus]

`` For now this patch of a collegue seems to resolve it:

diff --git a/Model/ResourceModel/File/Storage/Database.php b/Model/ResourceModel/File/Storage/Database.php
--- a/Model/ResourceModel/File/Storage/Database.php
+++ b/Model/ResourceModel/File/Storage/Database.php
@@ -238,6 +238,7 @@
      */
     public function loadByFilename(\Magento\MediaStorage\Model\File\Storage\Database $object, $filename, $path)
     {
+        return $this;
         $connection = $this->getConnection();

         $select = $connection->select()->from(

At the moment we get more than 19.2k requests in a week which generates this error and pollutes our monitoring.

or

diff --git a/Model/ResourceModel/File/Storage/Database.php b/Model/ResourceModel/File/Storage/Database.php
--- a/Model/ResourceModel/File/Storage/Database.php
+++ b/Model/ResourceModel/File/Storage/Database.php
@@ -238,6 +238,8 @@
      */
     public function loadByFilename(\Magento\MediaStorage\Model\File\Storage\Database $object, $filename, $path)
     {
+        return $this;
+
         $connection = $this->getConnection();

         $select = $connection->select()->from(

[vanpear]

I created a Composer Patch: magento/module-media-storage

diff --git a/Model/File/Storage/Synchronization.php b/Model/File/Storage/Synchronization.php
index 3ee2rd..8349152 111644
--- a/Model/File/Storage/Synchronization.php
+++ b/Model/File/Storage/Synchronization.php
@@ -10,6 +10,7 @@
 use Magento\Framework\Exception\FileSystemException;
 use Magento\Framework\Filesystem\Directory\WriteInterface as DirectoryWrite;
 use Magento\Framework\Filesystem\File\WriteInterface;
+use Magento\MediaStorage\Helper\File\Storage\Database as DatabaseStorageHelper;

 /**
  * Synchronize files from Db storage to local file system
@@ -31,15 +32,23 @@
     protected $mediaDirectory;

     /**
+     * @var DatabaseStorageHelper $databaseStorageHelper
+     */
+    protected $databaseStorageHelper;
+
+    /**
      * @param DatabaseFactory $storageFactory
      * @param DirectoryWrite $directory
+     * @param DatabaseStorageHelper $databaseStorageHelper
      */
     public function __construct(
         DatabaseFactory $storageFactory,
-        DirectoryWrite $directory
+        DirectoryWrite $directory,
+        DatabaseStorageHelper $databaseStorageHelper
     ) {
         $this->storageFactory = $storageFactory;
         $this->mediaDirectory = $directory;
+        $this->databaseStorageHelper = $databaseStorageHelper;
     }

     /**
@@ -51,6 +60,10 @@
      */
     public function synchronize($relativeFileName)
     {
+        if (!$this->databaseStorageHelper->checkDbUsage()) {
+            return;
+        }
+        
         /** @var $storage Database */
         $storage = $this->storageFactory->create();
         try {