Exception is not getting handled properly while adding a product to cart in the compare product page

[JasonTychons]

Preconditions and environment

• Magento version 2.4.6-p3
• PHP 8.1.18
• MySql 8.0.35-0ubuntu0.20.04.1 for Linux on x86_64 ((Ubuntu))

Steps to reproduce

• Login into the Magento using customer credentials
• Add a product to the compare list
• Got to my account page
• Click on compare
• Add the product to cart [In my case there was a Localized Exception thrown while adding it to the cart, there is a catch block in vendor/magento/module-checkout/Controller/Cart/Add.php line 164, but the exception is not caught and handled properly, instead JSON encoded page is returned]

Expected result

The exception should be handled and a message manager message should be displayed in the controller.

Actual result

The above-mentioned page is loaded with a JSON response

Additional information

No response

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @JasonTychons. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[JasonTychons]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @JasonTychons. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @JasonTychons, here is your Magento Instance: https://7c044137f5973a44c0717314c3a40a40.instances-prod.magento-community.engineering Admin access: https://7c044137f5973a44c0717314c3a40a40.instances-prod.magento-community.engineering/admin_ceac Login: a39236c9 Password: 464a1c71243c

[JasonTychons]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @JasonTychons. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @JasonTychons, here is your Magento Instance: https://7c044137f5973a44c0717314c3a40a40.instances-prod.magento-community.engineering Admin access: https://7c044137f5973a44c0717314c3a40a40.instances-prod.magento-community.engineering/admin_69a9 Login: 8da9b032 Password: 74d78d64c8f4

[JasonTychons]

https://github.com/magento/magento2/assets/89189460/a2c29396-e041-4b42-80c6-506eac16af63

I have attached a screen recorded video of replicating the bug in Magento version 2.4.6-p3

Issue is replicable in Magento 2.4.6-p3

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, here is your Magento Instance: https://7c044137f5973a44c0717314c3a40a40.instances-prod.magento-community.engineering Admin access: https://7c044137f5973a44c0717314c3a40a40.instances-prod.magento-community.engineering/admin_0740 Login: 89e4a7a4 Password: 1246eceef00d

[JasonTychons]

Hi @engcom-Bravo , Were you able to replicate the issue?

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @JasonTychons,

Thank you for the report and collaboration!

We were able to verify this issue on 2.4-develop. When manually throwing the LocalizedException in addProduct method of the class Magento\Checkout\Model\Cart, we got the below json response:

Hence confirming the issue.

Thank you.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10660 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[engcom-Bravo]

Hello,

Internal team has started to work on it

Thanks.

[engcom-Bravo]

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-10660 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-10660&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks