magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.39k stars 9.29k forks source link

Message queue topology is not considered in `setup:db:status` check #38225

Open mfickers opened 7 months ago

mfickers commented 7 months ago

Preconditions and environment

Steps to reproduce

  1. Run setup:upgrade to make sure db schema and data patches are up to date
  2. Add a new binding inside a queue_topology.xml file
  3. Run setup:db:status

Expected result

Actual result

Additional information

Magento_Amqp module contains a recurring setup script that will upgrade the queue topology: \Magento\Amqp\Setup\Recurring. Updates to the topology configuration will only take effect when setup:upgrade is run.

The command setup:db:status should inform the user if a setup:upgrade is needed or not. It is used by deployment scripts like the Magento 2 recipe of Deployer. If the command returns exit code 0, then setup:upgrade is skipped during deployment and the message queue topology might be out of date.

Release note

No response

Triage and priority

m2-assistant[bot] commented 7 months ago

Hi @mfickers. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 7 months ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 7 months ago

Hello @mfickers,

Thank you for the report and collaboration!

We were able to verify this issue on 2.4-develop. As mentioned in the steps we added a new binding inside queue_topology.xml, and ran the setup:db:status command. The topology binding was not considered and we got the the exit code 0 with the message "All modules are up to date".

Hence confirming this issue.

Thank you.

github-jira-sync-bot commented 7 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10641 is successfully created for this GitHub issue.

m2-assistant[bot] commented 7 months ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Vigneshmuthusamy commented 1 month ago

@mfickers @engcom-Hotel @engcom-November @engcom-Dash Any update on this issue? It's needed badly to reduce deployment time in adobe commerce

engcom-Hotel commented 1 month ago

Hello @Vigneshmuthusamy,

As I can see the related JIRA is still in the implementation phase. We will update you whenever it will mark as done, but meanwhile someone from community also raise the PR to fix this issue.

Thanks