Open m2-assistant[bot] opened 9 months ago
Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branch@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure. 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.Issue: Confirmed
once verification is complete. Hello @SerhiiMandrykin,
Thanks for the report and collaboration!
I know you have refactored the code for the quote address, it's good to have PR changes. But we need a Manual testing scenario
to test the related PR.
Please provide the same on the PR.
thanks
This issue is automatically created based on existing pull request: magento/magento2#38219: refactor quote address do validate method
Description (*)
While debugging address validation I noticed that
\Magento\Quote\Model\QuoteAddressValidator::doValidate
needs to be refactored and optimized.My PR includes readability improvements to the
doValidate
methodRelated Pull Requests
Manual testing scenarios (*)
Questions or comments
I think that the exceptions thrown are not relevant in this case and the messages like
Invalid customer address id %1
are not clear. I think we need to change it as well.Contribution checklist (*)