magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.48k stars 9.29k forks source link

[Issue] refactor quote address do validate method #38230

Open m2-assistant[bot] opened 9 months ago

m2-assistant[bot] commented 9 months ago

This issue is automatically created based on existing pull request: magento/magento2#38219: refactor quote address do validate method


Description (*)

While debugging address validation I noticed that \Magento\Quote\Model\QuoteAddressValidator::doValidate needs to be refactored and optimized.

My PR includes readability improvements to thedoValidate method

Related Pull Requests

Manual testing scenarios (*)

  1. Add a product to the shopping cart
  2. Go to the shopping cart

Questions or comments

I think that the exceptions thrown are not relevant in this case and the messages like Invalid customer address id %1 are not clear. I think we need to change it as well.

Contribution checklist (*)

m2-assistant[bot] commented 9 months ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 9 months ago

Hello @SerhiiMandrykin,

Thanks for the report and collaboration!

I know you have refactored the code for the quote address, it's good to have PR changes. But we need a Manual testing scenario to test the related PR.

Please provide the same on the PR.

thanks