Maps element not working - Page Builder missing appropriate CSP whitelist rules

[adamlavery]

Preconditions and environment

Magento OS 2.4.6

Steps to reproduce

1. Add a Map element to Page Builder

Expected result

Map should work and render correctly.

Actual result

Map doesn't work and doesn't render correctly in backend. Map doesn't work on frontend.

Additional information

Issue 1 is that Page Builder CSP whitelist is missing many CSP rules required for Google Maps to work correctly. This is how it should be:

<csp_whitelist xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Csp:etc/csp_whitelist.xsd">
    <policies>
        <policy id="connect-src">
            <values>
                <value id="vimeo" type="host">vimeo.com</value>
                <value id="google-maps" type="host">maps.googleapis.com</value>
            </values>
        </policy>
        <policy id="frame-src">
            <values>
                <value id="youtube" type="host">*.youtube.com</value>
                <value id="youtube_nocookie" type="host">*.youtube-nocookie.com</value>
            </values>
        </policy>
        <policy id="script-src">
            <values>
                <value id="google-maps" type="host">maps.googleapis.com</value>
            </values>
        </policy>
        <policy id="img-src">
            <values>
                <value id="google-img-static" type="host">*.gstatic.com</value>
                <value id="google-img-apis" type="host">*.googleapis.com</value>
            </values>
        </policy>
        <policy id="style-src">
            <values>
                <value id="google-css-staic" type="host">*.gstatic.com</value>
                <value id="google-css-apis" type="host">*.googleapis.com</value>
            </values>
        </policy>
    </policies>
</csp_whitelist>

Issue 2 is that latest Google Maps API fails due to overriding Array.from() in vendor\magento\magento2-base\lib\web\legacy-build.min.js. That has to be removed for the API to function correctly.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @adamlavery. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[adamlavery]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @adamlavery. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @adamlavery, here is your Magento Instance: https://16b86c0cc2f70973ea7db7c4aae7acfd.instances-prod.magento-community.engineering Admin access: https://16b86c0cc2f70973ea7db7c4aae7acfd.instances-prod.magento-community.engineering/admin_8ed2 Login: 45180ae5 Password: 6f73ad744e47

[adamlavery]

Issue confirmed:

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @adamlavery,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

• Add a Map element to Page Builder

Map doesn't work and doesn't render correctly in backend. Map doesn't work on frontend.

Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10704 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[pagesailor]

When will be a fix available for this? Prototype.js array.from implementation conflicts with Google maps API from v3.54. Forcing maps API version v3.53 was a viable workaround, but in 2024 april that version will be officially deprecated, causing all google maps implementations on Magento 2 to stop working. Considering that a minor Magento 2 version upgrade can take weeks or months (depending on the complexity of a project), any fix for this is already late. But still, if there will be an official fix for this, when will it be, and is it going to be backported? Are there any viable workarounds for this?

[alitopaloglu]

I've just applied a workaround to get rid of this issue by forcing to use the exact version of Google maps API v3.53. Thanks to @pagesailor

[pagesailor]

@alitopaloglu keep in mind that this workaround won't work after the middle of 2024 may, when the 3.53 Goole Maps API version will be retired.

[Djohn12]

Seems an official patch is now available: https://experienceleague.adobe.com/en/docs/commerce-knowledge-base/kb/troubleshooting/site-down-or-unresponsive/revised-patches-for-google-maps-access-loss-on-all-adobe-commerce-versions

It looks ok at first glance, will try it soon to see if it works as expected