Open ZandaBear opened 8 months ago
Hi @ZandaBear. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release@magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branch@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure. 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.Issue: Confirmed
once verification is complete. Hi @ZandaBear,
Thank you for reporting and collaboration.
Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.
Steps to reproduce
row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 200px
Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.
Thanks.
Hey @engcom-Bravo,
Correction, it appears "Media -> Image" is the only one functioning correctly. Updated initial report to match.
As you can see pictured, with "Banner" all three modes, in order from top to bottom of Cover, Contain, Auto are incorrectly locking the height at 100px.
So, the issue appears to be encountered when doing the following... -> Image is set as Background of row (not using Media->Image) -> Image is set as Banner background. -> Image is set as a Slider Image (not background).
A similar, but different issue encounter is that the image will always look like the top-most "cover" instance in the screenshot when... -> Image is set as Slider background (NOT as a slide).
@magento give me 2.4-develop instance
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.
Hi @engcom-Bravo, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_da4c Login: c3c96138 Password: 376a1edbb7c8
Hi @ZandaBear,
Thanks for your update.
Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.
Steps to reproduce
row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px.
Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.
Thanks.
@magento give me 2.4-develop instance
Hi @ZandaBear. Thank you for your request. I'm working on Magento instance for you.
Hi @ZandaBear, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_3642 Login: 6228b27c Password: f3bc4ebf81a7
@engcom-Bravo If you are setting the row to 100px then of course you must verify that the element's minimum height is not set to a greater value. For example, by default Magento sets banners to have a minimum height of 300px.
See screenshot for proof of the behavior I described in the initial post from the developer instance. For the screenshot, Row minimum height was set to 100px. Banner minimum height was cleared. Verified same behavior when the Row minimum height is cleared and Banner minimum is set to 100px.
As you can see, page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element. It is stretching or cropping the image used to a set height of 100px. The headers describe what each element is using. Only the top one is the correct size for the image of 200x200px.
Hi @ZandaBear,
Thanks for your update.
Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.
Steps to reproduce
page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element.Only the top one is the correct size for the image
Hence Confirming the issue.
Thanks.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10789 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Preconditions and environment
Steps to reproduce
Expected result
Said row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px
Actual result
Row or element is locked to 100px height. Image will be cropped, or scale reduced to fit within the so-called "minimum" height.
Additional information
Current workaround is to add a text box and, using the built in WYSIWYG, add an image. This allows admin to set both the height and width to scale however desired, but loses the functionality of the other elements available.
Release note
No response
Triage and priority