magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.45k stars 9.29k forks source link

Pagebuilder Minimum Height acting as both Minimum and Maximum #38310

Open ZandaBear opened 8 months ago

ZandaBear commented 8 months ago

Preconditions and environment

Steps to reproduce

  1. Go to pagebuilder in adminhtml.
  2. Add row.
  3. Add image to element as a row background, as a banner background, or as a slider slide. Make it 200x200px for this example.
  4. Set minimum height on row or element (either one) to any static value, 100px for this example.
  5. Save page and go to view changes on front end.

Expected result

Said row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px

Actual result

Row or element is locked to 100px height. Image will be cropped, or scale reduced to fit within the so-called "minimum" height.

Additional information

Current workaround is to add a text box and, using the built in WYSIWYG, add an image. This allows admin to set both the height and width to scale however desired, but loses the functionality of the other elements available.

Release note

No response

Triage and priority

m2-assistant[bot] commented 8 months ago

Hi @ZandaBear. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 8 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 8 months ago

Hi @ZandaBear,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

New

Screenshot from 2023-12-26 11-58-14

row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 200px

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

ZandaBear commented 8 months ago

Hey @engcom-Bravo,

Correction, it appears "Media -> Image" is the only one functioning correctly. Updated initial report to match. github 100px lock

As you can see pictured, with "Banner" all three modes, in order from top to bottom of Cover, Contain, Auto are incorrectly locking the height at 100px.

So, the issue appears to be encountered when doing the following... -> Image is set as Background of row (not using Media->Image) -> Image is set as Banner background. -> Image is set as a Slider Image (not background).

A similar, but different issue encounter is that the image will always look like the top-most "cover" instance in the screenshot when... -> Image is set as Slider background (NOT as a slide).

engcom-Bravo commented 8 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 8 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 8 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_da4c Login: c3c96138 Password: 376a1edbb7c8

engcom-Bravo commented 8 months ago

Hi @ZandaBear,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

Screenshot from 2024-01-03 13-08-49

row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px.

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

ZandaBear commented 8 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 8 months ago

Hi @ZandaBear. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 8 months ago

Hi @ZandaBear, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering Admin access: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering/admin_3642 Login: 6228b27c Password: f3bc4ebf81a7

ZandaBear commented 8 months ago

@engcom-Bravo If you are setting the row to 100px then of course you must verify that the element's minimum height is not set to a greater value. For example, by default Magento sets banners to have a minimum height of 300px.

See screenshot for proof of the behavior I described in the initial post from the developer instance. For the screenshot, Row minimum height was set to 100px. Banner minimum height was cleared. Verified same behavior when the Row minimum height is cleared and Banner minimum is set to 100px.

Magento Issue Proof

As you can see, page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element. It is stretching or cropping the image used to a set height of 100px. The headers describe what each element is using. Only the top one is the correct size for the image of 200x200px.

engcom-Bravo commented 8 months ago

Hi @ZandaBear,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

New (1)

page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element.Only the top one is the correct size for the image

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 8 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10789 is successfully created for this GitHub issue.

m2-assistant[bot] commented 8 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.