magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Mandatory fields in admin for Magento_Company do not match the fields on my account page #38360

Open jeroenalewijns opened 10 months ago

jeroenalewijns commented 10 months ago

Preconditions (*)

  1. PHP8.2
  2. Maria DB 10.6
  3. Magento Commerce (cloud) 2.4.6-p3

Steps to reproduce (*)

  1. Login in the admin and create a company
  2. Create for the company in step 1 a customer user
  3. Login as company on frontend http://www.xxx.nl/customer/account/login/
  4. Change created user details by clicking on the edit button
  5. Now the job title and phone number are required

Expected result (*)

  1. I expect that the job title and phone number aren't required because these aren't required in the admin section. Now you have to add these to change the details of the customer user.

Actual result (*)

  1. The job title and phone number are required.

I think that in the file vendor/magento/module-company/view/frontend/templates/company/management/dialog/customer/add.phtml ln26 and ln60 the data-validate="{required:true}" must be removed.

m2-assistant[bot] commented 10 months ago

Hi @jeroenalewijns. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 10 months ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


andrewbess commented 10 months ago

Hello @engcom-Dash Looks like we need to move this issue to the another project B2B, because contributors will not have possibility to fix it. Thank you in advance.

andrewbess commented 10 months ago

Hello @jeroenalewijns Thank you for your collaboration

It is true, the admin fields and frontend fields have different requirements

github-jira-sync-bot commented 10 months ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 10 months ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

engcom-Dash commented 9 months ago

Hi @jeroenalewijns

Thanks for reporting and collaboration.

Verified the issue on magento commerce dev instance and the issue is reproducible.

The job title and phone number are required in the account page and are not mandatory fields in admin for Magento_Company.

Please refer the screenshots attached.

38360_Confirmed
github-jira-sync-bot commented 9 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10887 is successfully created for this GitHub issue.

m2-assistant[bot] commented 9 months ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.