m2-assistant[bot]
commented
9 months ago Hi @mihaimatei. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance- upcoming 2.4.x release- For more details, review the Magento Contributor Assistant documentation.
- Add a comment to assign the issue:
@magento I am working on this -
To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
engcom-Dash
mihaimatei
magento-deployment-service[bot]
github-jira-sync-bot
Preconditions and environment
Steps to reproduce
Expected result
Import History shows correct execution time of the import when import is run by a user with non-en_US locale (de_CH and ro_RO tested)
Actual result
Import History shows incorrect execution time of the import when import is run by a user with non-en_US locale (de_CH and ro_RO tested)
Additional information
Problem appears in the \Magento\Framework\Stdlib\DateTime\Timezone::date method, in the switch branch of
case (!is_numeric($date)).Below is a summarised stack trace with relevant dumps which I've performed to track the issue:
IMPORT CSV - en_US locale admin user - CORRECT Execution Time
\Magento\ImportExport\Model\History::setExecutionTime($executionTime = 'Validation')\Magento\ImportExport\Model\History::setExecutionTime($executionTime = 'In Progress')\Magento\Framework\Stdlib\DateTime\Timezone::date($date = '2024-01-22 15:42:12')$locale:en_US$timezone:Europe/Berlincase (!is_numeric($date))matched1705938132date('Y-m-d H:i:s', $date):'2024-01-22 15:42:12'\Magento\ImportExport\Helper\Report::getExecutionTime($time = '2024-01-22 15:42:12')$this->timeZone->getDateTimeFormat(\IntlDateFormatter::SHORT)):M/d/yy h:mm a0$timeDiff->format('%Y-%m-%d %H:%I:%S')):'00-0-0 00:00:04'$timeDiff->format('%H:%I:%S')):'00:00:04'\Magento\ImportExport\Model\History::setExecutionTime($executionTime = '00:00:04')IMPORT CSV - de_CH locale admin user - WRONG Execution Time
\Magento\ImportExport\Model\History::setExecutionTime($executionTime = 'Validation')\Magento\ImportExport\Model\History::setExecutionTime($executionTime = 'In Progress')\Magento\Framework\Stdlib\DateTime\Timezone::date($date = '2024-01-22 15:59:51')$locale:de_CH$timezone:Europe/Berlincase (!is_numeric($date))matched$date:1815832740<---- PROBLEM HEREdate('Y-m-d H:i:s', $date):'2027-07-17 13:59:00'\Magento\ImportExport\Helper\Report::getExecutionTime($time = '2027-07-17 13:59:00')$this->timeZone->getDateTimeFormat(\IntlDateFormatter::SHORT)):dd.MM.yy HH:mm$timeDiff->days):1271,$timeDiff->format('%Y-%m-%d %H:%I:%S')):'03-5-25 22:58:56',$timeDiff->format('%H:%I:%S')):'22:58:56'\Magento\ImportExport\Model\History::setExecutionTime($executionTime = '22:58:56')The execution time might not seem important for user triggered csv imports, but when a custom import is built over the import-export module and imports run as scheduled tasks, import history execution time might be of importance to assess the health of the import, hence the severity can be evaluated even as S2.
In case of a custom import built on top of the import-export module, workaround for getting the correct execution time would be to set locale to en_US before triggering the import methods, but this might affect other data handling in the actually imported data.
Release note
No response
Triage and priority