Wrong Order total, the round is not applied to the price calculation.

mohammedTBB commented 7 months ago

Preconditions and environment

Magento version: 2.4.6-p3
Php version: 8.1
Tax Rate configuration (22%)
Tax configuration
Discount configuration (10%)
product 1 (hat) special price 733.61
product 2 (jacket) special price 569.67

Steps to reproduce

Two ways to reproduce the error: Method 1: 1- add product 1 3 to the cart 2- add product 2 2 to the cart 3- go to the checkout 4- apply the discount and use the country for the tax to be applied 5- create order

Method 2: 1- add product 2 2 to the cart 2- add product 1 3 to the cart 3- go to the checkout 4- apply the discount and use the country for the tax to be applied 5- create order

Expected result

The function round should be applied when calculating the price_after_discount, discount_amount and taxes amount. the actual total of the order should be 3667,52.

Actual result

Magento not doing the round function when calculating price_after_discount, discount_amount and taxes amount for the second product added to the cart. resulting in total 3667,51 when reproducing the error using method 1 and 3667,5 when reproducing the error using method 2.

hat-jacket

jacket-hat

Additional information

Here is the calculation that magento do, column (B+C) for first order, column (D+E) for the second order. the cells with background yellow where magento miscalculate the price (possibly by not rounding the price). the correct total is the result of the column (B+E) which are the correct calculations and matches the manual calculations.

Release note

No response

Triage and priority

[X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 7 months ago

Hi @mohammedTBB. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 7 months ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Dash commented 7 months ago

Hi @mohammedTBB

Thanks for reporting and collaboration.

Verified the issue on magento 2.4 dev instance and the issue is reproducible.

The round is not applied to the price calculation. We are getting wrong order total.

Steps to reproduce Two ways to reproduce the error: Method 1: 1- add product 1 3 to the cart 2- add product 2 2 to the cart 3- go to the checkout 4- apply the discount and use the country for the tax to be applied 5- create order

Method 2: 1- add product 2 2 to the cart 2- add product 1 3 to the cart 3- go to the checkout 4- apply the discount and use the country for the tax to be applied 5- create order

Please refer the attached screenshots.

github-jira-sync-bot commented 7 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11389 is successfully created for this GitHub issue.

m2-assistant[bot] commented 7 months ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

mohammedTBB commented 2 months ago

Hi,

Is there any patch available for this error? Any estimated timeline for when the fix might be released?

Thanks and Regards.

magento / magento2