magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.58k stars 9.32k forks source link

page layout xml of pagebuilder override the layout set by theme #38473

Open antoniocarboni opened 9 months ago

antoniocarboni commented 9 months ago

Preconditions and environment

Magento 2.4.6-p3 with Page Builder active

Steps to reproduce

Expected result

Change the default page layout from 2columns-left to 1column.

Actual result

The page layout of the category still remains 2 columns left

Additional information

Behavior and possible fix

The Magento_PageBuilder module sets several additional layouts to Magento in the page_layout/ folder The problem is that in addition to the layout it also sets a fixed layout to the category page with the catalog_category_view.xml file.

In my opinion this declaration is redundant or, perhaps, it is an error, because the layout declaration is already present on the catalog_category_view.xml of the Magento_Catalog module.

To resolve this issue simply remove layout="2columns-left" in the catalog_category_view file of Magento_PageBuilder as it would seem useless.

UPDATE: The issue is the same reported on this closed Issue

Release note

No response

Triage and priority

m2-assistant[bot] commented 9 months ago

Hi @antoniocarboni. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 9 months ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 9 months ago

Hello @antoniocarboni,

Thank you for the report and collaboration!

Verified this issue on 2.4-develop. With PageBuilder enabled and given configuration added in catalog_category_view.xml file in the app/design/frontend//<Custom_Theme>/Magento_Catalog/layout directory, we were able to reproduce the issue.

Please take a look at the screenshot below: When PageBuilder is enabled the layout configuration in custom theme is ignored, and default layout is applied

image

If we disable the PageBuilder, the layout in custom theme is applied

image

Hence confirming this issue.

Thank you.

github-jira-sync-bot commented 9 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11429 is successfully created for this GitHub issue.

m2-assistant[bot] commented 9 months ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.