Error when run command setup:upgrade with custom DB trigger

[manhtranisobar]

Preconditions and environment

• Magento 2.4.7-beta2

Steps to reproduce

• Access to database and create a custom trigger AFTER INSERT to store table with name trg_test_mview
• Run command bin/magento setup:upgrade

Expected result

The command bin/magento setup:upgrade is ran successfully

Actual result

An error appeared: Warning: Trying to access array offset on value of type null in vendor/magento/framework/Mview/View/Subscription.php on line 357

Additional information

• This issue come from function \Magento\Framework\Mview\TriggerCleaner::removeTriggers
• File line: vendor/magento/framework/Mview/TriggerCleaner.php:90

It seems there are 2 conditions to error appear: A custom trigger with name format which is different from other Mview triggers. This custom trigger is created for tables, that are used by Mview config.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @manhtranisobar. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[adarshkhatri]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @adarshkhatri. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @adarshkhatri, here is your Magento Instance: https://f8b27cd8fbd9bfb3201fb190d9b6db02.instances-prod.magento-community.engineering Admin access: https://f8b27cd8fbd9bfb3201fb190d9b6db02.instances-prod.magento-community.engineering/admin_d907 Login: 232bf8cd Password: 8c0dbb9bccb1

[manhtranisobar]

Hi @adarshkhatri , I have detailed issue reproduce steps, thank to check again.

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @manhtranisobar,

Thank you for the report and collaboration!

Tried to reproduce this issue on 2.4-develop, but in our case it is not reproducible. Created a AFTER INSERT custom trigger to store table with name trg_test_mview, please take a look at the screenshot below:

With the custom trigger added, while running bin/magento setup:upgrade we did not see any error.

Please let us know if we are missing anything.

Thank you.

[manhtranisobar]

Hi @engcom-November

It is strange, If you can use to debug logic of function \Magento\Framework\Mview\TriggerCleaner::removeTriggers then you can see It will try to create a dummy view with old_view id then It will be loaded by vendor/magento/framework/Mview/View/Subscription.php:357 so error appeared.

It see there are 2 conditions to error appear:

• A custom trigger with name format is difference Mview triggers
• This custom trigger is created for tables, that are used by Mview config This is exception stack:

  Warning: Trying to access array offset on value of type null in vendor/magento/framework/Mview/View/Subscription.php on line 357
  Subscription.php:357, Magento\Framework\Mview\View\Subscription->getProcessor()
  Subscription.php:339, Magento\Framework\Mview\View\Subscription->buildStatement()
  Subscription.php:215, Magento\Framework\Mview\View\Subscription->remove()
  Interceptor.php:50, Magento\Framework\Mview\View\Subscription\Interceptor->remove()
  View.php:232, Magento\Framework\Mview\View->unsubscribe()
  TriggerCleaner.php:90, Magento\Framework\Mview\TriggerCleaner->removeTriggers()
  Installer.php:1800, Magento\Setup\Model\Installer->removeUnusedTriggers()
  UpgradeCommand.php:148, Magento\Setup\Console\Command\UpgradeCommand->execute()
  Command.php:298, Symfony\Component\Console\Command\Command->run()
  Application.php:1040, Symfony\Component\Console\Application->doRunCommand()
  Application.php:301, Symfony\Component\Console\Application->doRun()
  Cli.php:116, Magento\Framework\Console\Cli->doRun()
  Application.php:171, Symfony\Component\Console\Application->run()
  magento:23, {main}()

[engcom-November]

Hello @manhtranisobar,

Thank you for the quick response!

As you mentioned, This custom trigger is created for tables, that are used by Mview config. Created a custom trigger for a table that already has triggers from mview configuration, with this we were able to reproduce this issue.

Please take a look at the screenshot below: Added a custom trigger to catalog_product_entity table, which already has 3 triggers.

While running setup:upgrade we got the error

Hence confirming the issue.

Thank you.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11487 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[github-jira-sync-bot]

:x: You don't have permission to export this issue.

[erwinschaap]

Any updates on this issue?