magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.32k forks source link

[Issue] Remove scope resolver usage #38566

Open m2-assistant[bot] opened 7 months ago

m2-assistant[bot] commented 7 months ago

This issue is automatically created based on existing pull request: magento/magento2#38554: Remove scope resolver usage


Description (*)

Admin URL settings is global and shouldn't be loaded depending on the current store.

m2-assistant[bot] commented 7 months ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 7 months ago

Hello @thomas-kl1,

Thank you for the report and collaboration!

Verified this on 2.4-develop. In app/code/Magento/Backend/App/Area/FrontNameResolver::isHostBackend() we do not need to pass the scope in $this->scopeConfig->getValue(), as Admin URL is global, instead default scope should be used. Hence this issue can be confirmed.

Thank you.

github-jira-sync-bot commented 7 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11736 is successfully created for this GitHub issue.

m2-assistant[bot] commented 7 months ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.