Missing validation message in custom date form field

hiren-gujarati commented 6 months ago

Preconditions and environment

Magento version: 2.4.6
Custom date field in any frontend form

Steps to reproduce

Add custom date field with date button in frontend form.
Open form which have custom date field.
Try to submit blank form.
All field show validation message as per there validation but date field not show any validation message

You can add custom date form field without calendar button using following code snippets,

<div class="field required">
    <label for="establishment_date" class="label">
        <span><?= /* @noEscape */ $block->escapeHtml(__('Establishment Date')) ?></span>
    </label>
    <div class="control">
        <input type="text"
                name="establishment_date"
                value=""
                title="<?= /* @noEscape */ $block->escapeHtml(__('Establishment Date')) ?>"
                class="input-text required-entry"
                id="establishment_date">
    </div>
</div>

<script type="text/javascript">
    require([
        'jquery',
        'mage/calendar'
    ], function ($) {
        $("#establishment_date").datepicker({
            dateFormat:'dd-mm-yy',
            changeYear: true,
            changeMonth: true,
        });
    });
</script>

Expected result

Date form field should show validation message same as other fields

Actual result

Date field not showing validation message without calendar button

Additional information

It is working fine when we add calendar button with date form field.

Date field validation is added after calendar button so, when we don't add button so, validation message is not showing. We can add button using following code snippet but it should work without button too.

<script type="text/javascript">
require([
    'jquery',
    'mage/calendar'
], function ($) {
    $("#establishment_date").datepicker({
        dateFormat:'dd-mm-yy',
        changeYear: true,
        changeMonth: true,
        buttonText: '',
        showOn: 'both'
    });
});
</script>

Error message is placed after button for date field from validation.js https://github.com/magento/magento2/blob/2.4-develop/lib/web/mage/validation.js#L1880-L1883

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 6 months ago

Hi @hiren-gujarati. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 6 months ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] commented 6 months ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-November commented 6 months ago

Hello @hiren-gujarati,

Thank you for the report and collaboration!

Verified this on 2.4-develop. The date-picker validation error is thrown only if the button is enabled, if the button is disabled even though the field is empty the error is not shown.

Please take a look at the screenshot:

Hence confirming this issue.

Thank you.

github-jira-sync-bot commented 6 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11800 is successfully created for this GitHub issue.

m2-assistant[bot] commented 6 months ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento / magento2