Category URL Path issue in multi-store

Nuranto commented 6 months ago

Preconditions and environment

Magento version 2.4.6 & 2.4.7

Steps to reproduce

Create 2 stores ( default = 1, other_store = 2), same category root assigned.
Create this category tree :
- Cat A (url key = a in default view. url key = other_a in store 2)
  - Cat AB (url key = b in default view)
Check catalog_category_entity_varchar table where attribute_id = (ID of url_path) and category_id = (ID of cat AB). You should see : a/b for store 0 and other-a/b for store 2.
Check frontend canonical url for store2 - AB category page. You should see https://.../other-a/b
Change url_key for cat AB, in default view, for b2
Check again catalog_category_entity_varchar table where attribute_id in (ID of url_path) and category_id = (ID of cat AB).
Check again canonical url for store2 AB category page.

Expected result

a/b2 for store 0 and other-a/b2 for store 2.
Url of category = https://.../other-a/b2, Canonical : https://.../other-a/b2

Actual result

a/b2 for store 0 and other-a/b for store 2.
Url of category = https://.../other-a/b2, Canonical : https://.../other-a/b

Additional information

No response

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 6 months ago

Hi @Nuranto. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 6 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] commented 6 months ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Dash commented 6 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Dash, here is your Magento Instance: https://b2c4c630e425172c56bb24d1a3bcaca5.instances-prod.magento-community.engineering Admin access: https://b2c4c630e425172c56bb24d1a3bcaca5.instances-prod.magento-community.engineering/admin_e95b Login: b0cf1897 Password: bd03976aface

engcom-Dash commented 6 months ago

Hi @Nuranto

Thanks for reporting and collaboration.

Verified the issue on magento 2.4 dev instance but the issue is not reproduceable.

Steps to reproduce

Create 2 stores ( default = 1, other_store = 2), same category root assigned.
Create this category tree : Cat A (url key = a in default view. url key = other_a in store 2) and Cat AB (url key = b in default view)
Check catalog_category_entity_varchar table where attribute_id = (ID of url_path) and category_id = (ID of cat AB). You should see : a/b for store 0 and other-a/b for store 2.
Check frontend canonical url for store2 - AB category page. You should see https://.../other-a/b
Change url_key for cat AB, in default view, for b2
Check again catalog_category_entity_varchar table where attribute_id in (ID of url_path) and category_id = (ID of cat AB).
Check again canonical url for store2 AB category page.

We are seeing the below results :

a/b2 for store 0 and other-a/b2 for store 2. Url of category = https://.../other-a/b2, Canonical : https://.../other-a/b2

Please refer the screenshots attached. Let us know if we have missed anything.

Nuranto commented 6 months ago

I did more test, on several projects I'm working on. Also tried with all third-extensions disabled. I can reproduce the issue in all cases. I tried to change some configuration, but cannot manage to find the missing step to reproduce :/

I also checked the code, i don't saw anywhere the code that updates the url_path on all stores. There's src/vendor/magento/module-catalog-url-rewrite/Model/Category/Plugin/Category/UpdateUrlPath.php but it only deals with new categories (if ($category->isObjectNew()) and src/vendor/magento/module-catalog-url-rewrite/Observer/CategoryUrlPathAutogeneratorObserver.php but it only deals with children.

I guess I'm missing something...

m2-assistant[bot] commented 6 months ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Delta commented 6 months ago

Hi @Nuranto,

Verified the issue on 2.4-develop and it is reproducible.

Hence, Confirming the issue.

Steps to reproduce:-

1.Create 2 stores ( default = 1, other_store = 1), same category root assigned. 2.Create this category tree : 3.Cat A (url key = a in default view. url key = other-a in store 1) Cat AB (url key = b in default view) 4.Check catalog_category_entity_varchar table where attribute_id = (ID of url_path) and category_id = (ID of cat AB). You should see : a/b for store 0 and other-a/b for store 2. 5.Check frontend canonical url for store2 - AB category page. You should see https://.../other-a/b 6.Change url_key for cat AB, in default view, for b2 7.Check again catalog_category_entity_varchar table where attribute_id in (ID of url_path) and category_id = (ID of cat AB). 8.Check again canonical url for store2 AB category page.

Please refer the attached screenshot.

Created one store other than default store

Same category assigned

Category A created and given url key = a in default view

url key = other-a in store 1 view

Category AB created and given url key = b in default view

Check catalog_category_entity_varchar table , a/b for store 0 and other-a/b for store 1.

frontend canonical url for store2 - AB category page. You should see https://.../other-a/b

Change url_key for cat AB, in default view, for b2

Check catalog_category_entity_varchar table