Open indykoning opened 3 weeks ago
Hi @indykoning. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment.
:exclamation: Automated tests can be triggered manually with an appropriate comment:
@magento run all tests
- run or re-run all required tests against the PR changes@magento run <test-build(s)>
- run or re-run specific test build(s)
For example: @magento run Unit Tests
<test-build(s)>
is a comma-separated list of build names.
You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.
For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.
@magento create issue
Description (*)
This allows loading nonexistent orders by customer. Before: loading an empty order as a customer would trigger this check resulting in "No such entity with orderId = ", as there is no orderId yet since it doesn't exist yet. Which means the order should be allowed.
After: Loading an empty order results in the empty order being returned, if it is a preexisting order the old checks apply
Contribution checklist (*)
Resolved issues: