magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Product Rating: Rating isn't Available in Admin Panel New Review page #38670

Closed hiren-gujarati closed 5 months ago

hiren-gujarati commented 6 months ago

Preconditions and environment

Steps to reproduce

  1. Go to Admin > Marketing > All Reviews > New Review > Choose any product
  2. It will show 'Rating isn't Available' for Product Rating field (it is correct because Visibility is not selected yet)
  3. Select Store in Visibility multi-select field.

After select/change Visibility it is not showing Product Ratings every time.

Expected result

It should send ajax request for update rating and show Product Rating every time when user select/change visibility.

image

Actual result

It is not sending ajax request and not showing Product Rating every time. Need to hard refresh multiple time to see Product Rating on select/change of visibility field.

image

Additional information

Due to any reason mentioned JS function is not calling every time on page load and it is causing issue.

https://github.com/magento/magento2/blob/2.4.7/app/code/Magento/Review/Block/Adminhtml/Add.php#L107-L109

Release note

No response

Triage and priority

m2-assistant[bot] commented 6 months ago

Hi @hiren-gujarati. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 6 months ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Delta commented 6 months ago

Hi @hiren-gujarati,

Verified the issue on 2.4-develop and 2.4.7 and it is not reproducible.

Steps to reproduce:-

1.Go to Admin > Marketing > All Reviews > New Review >Choose any product 2.It will show 'Rating isn't Available' for Product Rating field (it is correct because Visibility is not selected yet) 3.Select Store in Visibility multi-select field. 4.Verify the behaviour

Please refer the attached screenshot and let us if we are missing something.

Screenshot 2024-04-29 at 9 27 43 PM Screenshot 2024-04-29 at 1 36 30 PM Screenshot 2024-04-29 at 1 55 57 PM Screenshot 2024-04-29 at 1 59 53 PM

After select/change Visibility it is showing Product Ratings every time

Screenshot 2024-04-29 at 9 24 19 PM Screenshot 2024-04-29 at 9 24 39 PM
github-jira-sync-bot commented 6 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11875 is successfully created for this GitHub issue.

engcom-Delta commented 6 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Delta, here is your Magento Instance: https://cf48f0b7c7f8e7273b1adcae94464df1.instances-prod.magento-community.engineering Admin access: https://cf48f0b7c7f8e7273b1adcae94464df1.instances-prod.magento-community.engineering/admin_c5dd Login: 347b5fb9 Password: ce2e30924df2

hiren-gujarati commented 6 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 6 months ago

Hi @hiren-gujarati. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 6 months ago

Hi @hiren-gujarati, here is your Magento Instance: https://cf48f0b7c7f8e7273b1adcae94464df1.instances-prod.magento-community.engineering Admin access: https://cf48f0b7c7f8e7273b1adcae94464df1.instances-prod.magento-community.engineering/admin_da0f Login: 50f55ed1 Password: 0a6aaf579339

hiren-gujarati commented 6 months ago

Hi @engcom-Delta

As mentions before Rating field is not visible every time so, initially it might work for you but if you navigate to other page and back to new review page then it is not working almost 9 out of 10 times. Please check attached video of this issue, I have tested on above 2.4-develop instance.

38670.webm

Mugentoki commented 6 months ago

Setting the visibility for rating attributes, indeed fixed it for me. Might be possible, that with the update to 2.4.7 (or even other versions?) the ratings loose their visibility.

engcom-Dash commented 6 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Dash, here is your Magento Instance: https://cf48f0b7c7f8e7273b1adcae94464df1.instances-prod.magento-community.engineering Admin access: https://cf48f0b7c7f8e7273b1adcae94464df1.instances-prod.magento-community.engineering/admin_03b1 Login: eaf455c8 Password: 2a441791938f

engcom-Dash commented 6 months ago

Hi @hiren-gujarti

Thanks for reporting and collaboration.

Verified the issue on magneto 2.4 dev instance but the issue is still not reproducible.

Steps to reproduce Go to Admin > Marketing > All Reviews > New Review > Choose any product It will show 'Rating isn't Available' for Product Rating field (it is correct because Visibility is not selected yet) Select Store in Visibility multi-select field.

We are able to see the rating.

Please refer the attached screenrecording. Let us know if we missed anything.

https://github.com/magento/magento2/assets/60198592/52467397-103f-4337-812a-58b1caeb10be

engcom-Delta commented 5 months ago

Hi @hiren-gujarati ,

Awaiting your reply on this issue to move further.

Thanks,

engcom-Delta commented 5 months ago

Hello @hiren-gujarati ,

As there is no activity on this issue for a long time, we believe the issue has been resolved, hence closing this issue. Feel free to raise a new issue or reopen this if you need more assistance.

Thanks,