magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Vault/Stored Payment Methods not selected value when changing the uncheck/check my billing address and shipping address are the same #38718

Closed vbuiendertech closed 2 months ago

vbuiendertech commented 6 months ago

Preconditions and environment

Steps to reproduce

  1. Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.)
  2. Selected any payment method on the Stored Payment method
  3. Uncheck the option My billing and shipping address are the same. => Click the update with the new address.

Expected result

After unchecking/checking the checkbox, my billing and shipping address are the same, and click on the Update button. Selecting "My billing and shipping address are the same" should not de-select the selected stored credit card.

Actual result

Selecting “My billing and shipping address are the same” under the stored credit card would de-select the selected stored credit card.

Screenshot 2024-05-14 at 10 40 44 Screenshot 2024-05-14 at 10 40 54

This is my video test:

https://drive.google.com/file/d/1nq3MZpX5GKbtVaz_5g1WdyAYF0RcUL2A/view

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 6 months ago

Hi @vbuiendertech. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 6 months ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Delta commented 6 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Delta, here is your Magento Instance: https://2ff49090b319f9878babdc8527895b2a.instances-prod.magento-community.engineering Admin access: https://2ff49090b319f9878babdc8527895b2a.instances-prod.magento-community.engineering/admin_cfed Login: 49cb31cc Password: 0a55a07c226d

engcom-Delta commented 5 months ago

@magento give me 2.4.7 instance

magento-deployment-service[bot] commented 5 months ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 5 months ago

Hi @engcom-Delta, here is your Magento Instance: https://80fe48559389eaa2c094b83390086698.instances-prod.magento-community.engineering Admin access: https://80fe48559389eaa2c094b83390086698.instances-prod.magento-community.engineering/admin_088d Login: 016cbbd0 Password: 19f482e3a791

engcom-Delta commented 5 months ago

Hi @vbuiendertech ,

Thanks for reporting and collaboration.

Verified the issue in magento 2.4-develop instance and the issue is not reproducible.

Preconditions:-

Braintree Payment Method (with Stored Cards)

Steps to reproduce:-

1.Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.) 2.Selected any payment method on the Stored Payment method 3.Uncheck the option My billing and shipping address are the same. => Click the update with the new address.

After unchecking/checking the checkbox, my billing and shipping address are the same, and click on the Update button. Selecting "My billing and shipping address are the same" doesn't de-select the selected stored credit card.

https://github.com/magento/magento2/assets/51681379/f1cdcc9c-1aad-4006-a1cd-7165222e8348

vbuiendertech commented 5 months ago

Hi @engcom-Delta

Thank you for response.

But you tested on the Magento 2.4.7 and Braintree Payment v4.6.1.

My issue existed on Magento 2.4.6-p5 ( this Magento version uses Braintree Payment v4.5.0-p1)

Can you please test this issue on Magento 2.4.6-p5 and Braintree Payment v4.5.0-p1? and provide patches to resolve this issue before we upgrade to Magento 2.4.7?

Thank you in advance!

VietBui

vbuiendertech commented 5 months ago

Hi @engcom-Delta

I will reopen this ticket.

Please confirm with me.

My issue existed on Magento 2.4.6-p5 ( this Magento version uses Braintree Payment v4.5.0-p1)

Thank you so much.

engcom-Delta commented 5 months ago

Hi @vbuiendertech ,

Thanks for reporting and collaboration.

Verified the issue in latest magento 2.4.7 instance and the issue is not reproducible.

Preconditions:-

Braintree Payment Method (with Stored Cards)

Steps to reproduce:-

1.Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.) 2.Selected any payment method on the Stored Payment method 3.Uncheck the option My billing and shipping address are the same. => Click the update with the new address.

After unchecking/checking the checkbox, my billing and shipping address are the same, and click on the Update button. Selecting "My billing and shipping address are the same" doesn't de-select the selected stored credit card.

https://github.com/magento/magento2/assets/51681379/79af7807-0075-40e5-9f71-7fd0d0367ba0

vbuiendertech commented 5 months ago

Hi @engcom-Delta,

Thanks for reporting and collaboration.

I know this issue can't be reproduced on Magento 2.4.7

But you can reproduce this issue on Magento 2.4.6-p5.

Currently, my site uses Magento 2.4.6 -p5 and still hasn't plan upgrade to Magento 2.4.7

Can you provide patches to fix this issue on the Magento 2.4.6-p5?

Thank you in advance!

engcom-Delta commented 5 months ago

Hi @vbuiendertech ,

Thanks for reporting and collaboration.

Verified the issue in magento 2.4.6-p5 instance and the issue is reproducible.

Preconditions:-

Braintree Payment Method (with Stored Cards)

Steps to reproduce:-

1.Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.) 2.Selected any payment method on the Stored Payment method 3.Uncheck the option My billing and shipping address are the same. => Click the update with the new address.

Selecting “My billing and shipping address are the same” under the stored credit card would de-select the selected stored credit card.

https://github.com/magento/magento2/assets/51681379/006c832a-472e-408e-a13f-3df2bdd9bf7b

We will get back to you soon for the patch required by you, meanwhile we are putting this issue on hold.

engcom-Delta commented 2 months ago

Hi @vbuiendertech ,

Thanks for reporting and collaboration. Verified the issue in magento 2.4.6-p5 instance and the issue is reproducible. However, Issue is not replicable in latest version i.e. 2.4.7-p2. Issue must have been addressed in latest versions, we suggest you to please upgrade your version.

Preconditions:- Braintree Payment Method (with Stored Cards)

Steps to reproduce:- 1.Add a product to the cart and redirect to the checkout/#payment page. (Step 2 on the checkout page.) 2.Selected any payment method on the Stored Payment method 3.Uncheck the option My billing and shipping address are the same. => Click the update with the new address. Selecting “My billing and shipping address are the same” under the stored credit card would de-select the selected stored credit card.

https://github.com/user-attachments/assets/e2f9ba6f-087c-4aff-b5a6-87b885b1503b

Thanks.