Error Cannot return null for non-nullable field "SelectedShippingMethod.carrier_code"

[ThomasHWeb]

Preconditions and environment

• Magento 2.4.7
• In my production environment, I watched this error message in logs after upgrading to Magento 2.4.7. It triggers because of the changes made in vendor/magento/module-quote-graph-ql/Model/Resolver/ShippingAddress/SelectedShippingMethod.php related to this commit #36606.

Somehow, the shipping method from address has not been reset before, and the rate associate is not in the rates list. $carrierCode and $methodCode variables remain null after the foreach block.

Steps to reproduce

Not able to reproduce it in my local environment. It seems to be a very tricky use case.

Expected result

To not have selected address if last shipping method saved not matched with the new rates list.

Actual result

Cart GraphQL data are not returned in storefront because of this error.

Additional information

No response

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @ThomasHWeb. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @ThomasHWeb ,

Thanks for reporting and collaboration.

Verified the issue in magento 2.4.7 instance and the issue is not reproducible.

Steps to reproduce:-

1.Send a Graphql query and verify

query { cart(cart_id: "") { shipping_addresses { selected_shipping_method { carrier_code method_code } available_shipping_methods { carrier_code method_code } } } }

We are not getting any error while sending the graphql query,

Please add some more details with screenshots to debug this issue.

Thanks,

[engcom-Delta]

Hi @ThomasHWeb ,

Awaiting your reply to move further on this issue.

Thanks,

[engcom-Delta]

Hello @ThomasHWeb ,

As there is no activity on this issue for a long time, we believe the issue has been resolved, hence closing this issue. Feel free to raise a new issue or reopen this if you still face it.

Thank you.

[owandrejavidovic]

The issue is mutation { setShippingMethodsOnCart( input: { cart_id: "walNToYaEaFeN4QKFoQwz9hlChT124Gn" owNewsletterSubscribe: false shipping_methods: [{ carrier_code : "your_method" method_code : "your_method" }] } ) { cart { email id is_virtual owNewsletterSubscribe shipping_addresses { selected_shipping_method{ carrier_code carrier_title } street telephone uid } total_quantity } } }

Response: { "data": { "setShippingMethodsOnCart": { "cart": { "email": "peter.novak+41@optiweb.com", "id": "fPM15smAU0qoOacz8LT7XlfXEenvTT9p", "is_virtual": false, "owNewsletterSubscribe": false, "shipping_addresses": [ { "selected_shipping_method": null, // this is the issue "street": [ "Pod kostanji 8" ], "telephone": "041676376", "uid": 233034 } ], "total_quantity": 1 } } } }