magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

[Issue] The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules #38742

Closed m2-assistant[bot] closed 3 months ago

m2-assistant[bot] commented 4 months ago

This issue is automatically created based on existing pull request: magento/magento2#38726: The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules


Description (*)

In instance where we have custom shipping methods without shipping rates validation rules, the loader blocks the shipping methods after the postcode is changed in the shipping address during checkout and does not disappear.

File: vendor/magento/module-checkout/view/frontend/web/js/model/shipping-rates-validator.js

image

image

Contribution checklist (*)

m2-assistant[bot] commented 4 months ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


m2-assistant[bot] commented 4 months ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 4 months ago

Hello @mattkrupnik,

Thank you for the report and collaboration!

Verified this issue on 2.4-develop. With a custom shipping method without validation rules, if the postal code is changed in the shipping address form, the shipping methods will keep loading, blocking the user to select a shipping method.

Note: This only happens when the custom shipping methods are enabled without validation rules, if another shipping method with validation is enabled this issue does not occour.

Take a look at the screenshot below:

image

Please find the attached custom shipping module used to reproduce this issue. ShipVendor.zip

Hence confirming this issue.

Thank you.

github-jira-sync-bot commented 4 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11993 is successfully created for this GitHub issue.

m2-assistant[bot] commented 4 months ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-Bravo commented 3 months ago

Hello,

Internal team has started to work on it.

Thanks.

engcom-Bravo commented 3 months ago

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-11993 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-11993&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks