Set Custom Price In Admin Blocked By CSP

jorgb90 commented 5 months ago

Preconditions and environment

Magento 2.4.7

Steps to reproduce

Go to admin
Create order
Pick customer
Pick item
Try to alter the price through Custom Price checkbox

Expected result

Being able to set a Custom Price.

Actual result

Not working, because its blocked by CSP.

Refused to execute inline event handler because it violates the following Content Security Policy directive: "directive". Either the 'unsafe-inline' keyword, a hash ('sha256-...'), or a nonce ('nonce-...') is required to enable inline execution.

Additional information

<script nonce="c29oNmVsdjczMGJncmU2Nmd2czZ6a3ZqYTYwcmdpdmE&#x3D;">
var deps = [];
deps.push('Magento_Sales/order/create/form')
deps.push('mage/adminhtml/grid');
require(deps, function() {

    //<![CDATA[

    sales_order_create_search_gridJsObject = new varienGrid("sales_order_create_search_grid",'https\u003A\u002F\u002Fwww.url.com\u002Fadmin\u002Fsales\u002Forder_create\u002FloadBlock\u002Fblock\u002Fsearch_grid\u002Fkey\u002Fb6656c180e813b5118400b19cbf002ff449335de3a18958a2ab1751fd4646b0e\u002F','page','sort','dir','filter');

    sales_order_create_search_gridJsObject.useAjax = '1';

    sales_order_create_search_gridJsObject.rowClickCallback = order.productGridRowClick.bind(order);
    sales_order_create_search_gridJsObject.checkboxCheckCallback = order.productGridCheckboxCheck.bind(order);
    sales_order_create_search_gridJsObject.filterKeyPressCallback = order.productGridFilterKeyPress;
    sales_order_create_search_gridJsObject.initRowCallback = order.productGridRowInit.bind(order);
    sales_order_create_search_gridJsObject.initGridRows();

    //]]>

});
</script>

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 5 months ago

Hi @jorgb90. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 5 months ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Delta commented 5 months ago

Hi @jorgb90 ,

Thanks for reporting and collaboration.

Verified the issue in magento on latest 2.4.7 and 2.4-develop instance and the issue is not reproducible.

Steps to reproduce:-

1.Go to admin 2.Create order 3.Pick customer 4.Pick item 5.Try to alter the price through Custom Price checkbox

Please find attached the video and let us know if we missed something.

https://github.com/magento/magento2/assets/51681379/64758658-946d-42a6-85e1-a1406b405206

jorgb90 commented 5 months ago

@engcom-Delta Thanks for checking this issue. For us the box won't even appear when clicking on Custom Price. In the console it then outputs that CSP is blocking it. I am going to look into it again.

jorgb90 commented 5 months ago

@engcom-Delta It seemed that a module was overwriting the grid.phtml so we needed to update it to be compatible again. Unfortunately didn't found this before opening the issue.

magento / magento2